public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Shuah Khan <shuahkh@osg.samsung.com>, <linux-api@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Davidlohr Bueso <dave@stgolabs.net>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 1/5] selftests: Add futex functional tests
Date: Tue, 12 May 2015 09:10:49 -0700	[thread overview]
Message-ID: <D1777231.CC5D0%dvhart@linux.intel.com> (raw)
In-Reply-To: <20150512100256.GA5122@rei.suse.de>

On 5/12/15, 3:02 AM, "Cyril Hrubis" <chrubis@suse.cz> wrote:

>Hi!
>> I'm happy to do that, but I would like to make sure I'm doing the right
>> thing.
>
>The right thing here is to add -pthread to CFLAGS which sets both flags
>for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I
understand we have a number of gcc-isms in our build - but do we want to
add more?

I'm also struggling to find any kind of prescribed documentation on this
beyond the short blurb in the gcc man page which describes what this
option does, but not when to use it. I'll need something concrete to
justify changes to testcase Makefiles to Shuah.

Unfortunately, all these options are functional for me, while some are not
for Shuah, so I'm currently having to rely on documentation which seems
pretty sparse.

-- 
Darren Hart
Intel Open Source Technology Center




  reply	other threads:[~2015-05-12 16:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 22:09 [GIT PULL v2] selftest: Add futex functional tests Darren Hart
2015-05-08 22:09 ` [PATCH 1/5] selftests: " Darren Hart
2015-05-11 18:06   ` Shuah Khan
2015-05-11 18:22     ` Darren Hart
2015-05-11 18:55       ` Shuah Khan
2015-05-11 19:47         ` Darren Hart
2015-05-11 20:51           ` Shuah Khan
2015-05-11 21:50             ` Darren Hart
2015-05-11 22:21               ` Shuah Khan
2015-05-11 22:21                 ` Shuah Khan
2015-05-11 23:07                   ` Darren Hart
2015-05-11 23:23                     ` John Stultz
2015-05-12 10:02                     ` Cyril Hrubis
2015-05-12 16:10                       ` Darren Hart [this message]
2015-05-12 16:47                         ` Shuah Khan
2015-05-12 17:05                           ` Darren Hart
2015-05-12 17:14                             ` Shuah Khan
2015-05-12 20:05                         ` Cyril Hrubis
2015-05-12 20:15                           ` Darren Hart
2015-05-12 20:40                             ` Shuah Khan
2015-05-12 20:54                               ` Darren Hart
2015-05-12 21:17                                 ` Shuah Khan
2015-05-12 21:21                                   ` Shuah Khan
2015-05-13  3:34                                     ` Darren Hart
2015-05-08 22:09 ` [PATCH 2/5] selftest/futex: Update Makefile to use lib.mk Darren Hart
2015-05-08 22:09 ` [PATCH 3/5] selftest/futex: Increment ksft pass and fail counters Darren Hart
2015-05-08 22:09 ` [PATCH 4/5] selftest: Add futex tests to the top-level Makefile Darren Hart
2015-05-08 22:09 ` [PATCH 5/5] kselftest: Add exit code defines Darren Hart
  -- strict thread matches above, loose matches on Subject: below --
2015-03-27 22:17 [GIT PULL] selftest: Add futex functional tests Darren Hart
2015-03-27 22:17 ` [PATCH 1/5] selftests: " Darren Hart
2015-05-06 17:28   ` Shuah Khan
2015-05-06 18:04     ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D1777231.CC5D0%dvhart@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=chrubis@suse.cz \
    --cc=dave@stgolabs.net \
    --cc=john.stultz@linaro.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox