From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbbHEUm2 (ORCPT ); Wed, 5 Aug 2015 16:42:28 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:34506 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbbHEUm0 convert rfc822-to-8bit (ORCPT ); Wed, 5 Aug 2015 16:42:26 -0400 From: John Savanyo To: "dmitry.torokhov@gmail.com" , Philip Moltmann CC: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "pv-drivers@vmware.com" , Xavier Deguillard , "akpm@linux-foundation.org" Subject: Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node. Thread-Topic: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node. Thread-Index: AQHQz7x49IsJ/bnFgEykOUs433QrIJ3+UdAA//+NJYA= Date: Wed, 5 Aug 2015 20:42:25 +0000 Message-ID: References: <20150612161513.GA23859@dtor-pixel> <1434134610-2831-6-git-send-email-moltmann@vmware.com> <20150805201459.GA16009@kroah.com> <1438806166.31263.203.camel@vmware.com> <20150805203322.GA39610@dtor-ws> In-Reply-To: <20150805203322.GA39610@dtor-ws> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.113.160.246] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I agree that version number tracking is not perfect. But it is valuable for us to use as a rough indication that we have attempted to back port some appropriate subset of patches from mainline to a sustaining distro release without having to diff the code. -John On 8/5/15, 1:33 PM, "dmitry.torokhov@gmail.com" wrote: >On Wed, Aug 05, 2015 at 08:22:35PM +0000, Philip Moltmann wrote: >> Hi, >> >> > > MODULE_AUTHOR("VMware, Inc."); >> > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver"); >> > > -MODULE_VERSION("1.3.2.0-k"); >> > > +MODULE_VERSION("1.3.3.0-k"); >> > >> > This constant change of module version is annoying, is it really even >> > needed? >> > >> > I'll take this, but seriously consider just dropping it entirely as >> > it >> > doesn't mean anything now that the driver is in the kernel tree. >> >> I think this is meant so that we can track which patches got backported >> into RHEL and SLES. > >That assumes that RHEL and SLES always take everything that is in >mainline, which I would not count. I.e if you have a security fix and >also change version to 1.3.4.0-k and RedHat picks it up is the driver >that they have really 1.3.4.0-k? If not then what? > >You really need to keep track of the substance of the changes needing to >go into each distribution. > >Thanks. > >-- >Dmitry