Re: [PATCH 1/3] Staging: wilc1000: Remove null check before kfree

["Dilger, Andreas" <andreas.dilger@intel.com>]

On 2015/08/10, 2:00 AM, "Shraddha Barke" <shraddha.6596@gmail.com> wrote:

>kfree on NULL pointer is a no-op.

Hi, please don't CC the hpdd-discuss list, nor Oleg or I for patches
unrelated to Lustre.

Cheers, Andreas

>This patch uses the following semantic patch to find such an instance
>where NULL check is present before kfree.
>
>// <smpl>
>@@ expression E; @@
>- if (E != NULL) { kfree(E); }
>+ kfree(E);
>@@ expression E; @@
>- if (E != NULL) { kfree(E); E = NULL; }
>+ kfree(E);
>+ E = NULL;
>// </smpl>smpl>
>
>Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
>---
> drivers/staging/wilc1000/linux_wlan.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/wilc1000/linux_wlan.c
>b/drivers/staging/wilc1000/linux_wlan.c
>index 3e55a8a..3dcd6e5 100644
>--- a/drivers/staging/wilc1000/linux_wlan.c
>+++ b/drivers/staging/wilc1000/linux_wlan.c
>@@ -2343,8 +2343,7 @@ int mac_ioctl(struct net_device *ndev, struct ifreq
>*req, int cmd)
> 
> done:
> 
>-	if (buff != NULL)
>-		kfree(buff);
>+	kfree(buff);
> 
> 	return s32Error;
> }
>-- 
>2.1.0
>
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division