public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Eric Biggers" <ebiggers@kernel.org>,
	"James Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
	linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	regressions@lists.linux.dev, kernel@collabora.com,
	"Tejun Heo" <tj@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Kees Cook" <keescook@chromium.org>, "Torsten Duwe" <duwe@lst.de>,
	"H. Peter Anvin" <hpa@zytor.com>, "Theodore Ts'o" <tytso@mit.edu>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [v3 PATCH] hwrng: core - Remove add_early_randomness
Date: Thu, 23 May 2024 13:07:17 +0300	[thread overview]
Message-ID: <D1GXVKBX8S1K.BU96RSL9PD2E@kernel.org> (raw)
In-Reply-To: <Zk8TXz1hfA8_Uu9R@gondor.apana.org.au>

On Thu May 23, 2024 at 12:58 PM EEST, Herbert Xu wrote:
> On Thu, May 23, 2024 at 12:53:04PM +0300, Jarkko Sakkinen wrote:
> >
> > Just throwing something because came to mind, not a serious suggestion.
> > 
> > In crypto_larval_lookup I see statements like this:
> > 
> > 	request_module("crypto-%s", name);
> > 
> > You could potentially bake up a section/table to vmlinux which would
> > have entries like:
> > 
> > 	"module name", 1/0
> > 
> > '1' would mean built-in. Then for early randomness use only stuff
> > that is built-in.
>
> This early random stuff is obsolete not just because we have a
> kernel thread doing the same thing, but moreover random.c itself
> has been modified so that it is no longer starved of entropy on
> startup.  There is no reason to feed any early randomness.

As a feature that would still sometimes nice to have. I've
sometimes wished there was "lsmod -b" or similar to display
built-in stuff ;-)

So overally I think it was good to have at least documented
here... 

BR, Jarkko

  reply	other threads:[~2024-05-23 10:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0f68c283ff4bbb89b8a019d47891f798c6fff287.camel@HansenPartnership.com>
     [not found] ` <CAMj1kXHi4r8KY9GvX573kwqvLpMfX-J=K2hWiGAKkf5bnicwYQ@mail.gmail.com>
     [not found]   ` <0d260c2f7a9f67ec8bd2305919636678d06000d1.camel@HansenPartnership.com>
     [not found]     ` <CAMj1kXFE_R_x10BVkU+8vrMz0RHiX0+rz-ZL+w08FH2CLQHZXA@mail.gmail.com>
     [not found]       ` <66ec985f3ee229135bf748f1b0874d5367a74d7f.camel@HansenPartnership.com>
     [not found]         ` <dfb0d930-7cbe-46c5-be19-d132b4906ecf@notapiano>
     [not found]           ` <D1C2NPOBHAHK.20O4IME8OK1FH@kernel.org>
     [not found]             ` <20240518043115.GA53815@sol.localdomain>
     [not found]               ` <ZkhS1zrobNwAuANI@gondor.apana.org.au>
     [not found]                 ` <00bcfa65-384d-46ae-ab8b-30f12487928b@notapiano>
2024-05-21  2:53                   ` [v2 PATCH] crypto: api - Do not load modules if called by async probing Herbert Xu
2024-05-21 19:37                     ` Nícolas F. R. A. Prado
2024-05-22  5:37                       ` [v3 PATCH] hwrng: core - Remove add_early_randomness Herbert Xu
2024-05-22 11:51                         ` Jarkko Sakkinen
2024-05-23  4:50                           ` Herbert Xu
2024-05-22 19:19                         ` Nícolas F. R. A. Prado
2024-05-22 22:53                         ` Linus Torvalds
2024-05-23  4:49                           ` Herbert Xu
2024-05-23  9:53                             ` Jarkko Sakkinen
2024-05-23  9:58                               ` Herbert Xu
2024-05-23 10:07                                 ` Jarkko Sakkinen [this message]
2024-05-23 10:02                               ` Jarkko Sakkinen
2024-05-23 10:40                             ` Torsten Duwe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D1GXVKBX8S1K.BU96RSL9PD2E@kernel.org \
    --to=jarkko@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=duwe@lst.de \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel@collabora.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=regressions@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox