From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>,
<keyrings@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <lukas@wunner.de>
Subject: Re: [PATCH 0/2] ecdsa: Use ecc_digits_from_bytes to simplify code
Date: Thu, 30 May 2024 08:08:22 +0300 [thread overview]
Message-ID: <D1MPWI6C2ZCW.F08I9ILD63L4@kernel.org> (raw)
In-Reply-To: <20240529230827.379111-1-stefanb@linux.ibm.com>
On Thu May 30, 2024 at 2:08 AM EEST, Stefan Berger wrote:
> Simplify two functions that were using temporary byte arrays for
> converting too-short input byte arrays to digits. Use ecc_digits_from_bytes
> since this function can now handle an input byte array that provides
> less bytes than what a coordinate of a curve requires - the function
> provides zeros for the missing (leading) bytes.
>
> See: c6ab5c915da4 ("crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes")
>
> Regards,
> Stefan
>
> Stefan Berger (2):
> crypto: ecdsa - Use ecc_digits_from_bytes to create hash digits array
> crypto: ecdsa - Use ecc_digits_from_bytes to convert signature
>
> crypto/ecdsa.c | 29 ++++++-----------------------
> 1 file changed, 6 insertions(+), 23 deletions(-)
BTW, would it make sense split ecdsa signature encoding to its own patch
in my next patch set version and name it ecdsa_* style and put it to
ecdsa.c?
Just asking this because the part should be the same same for any ECDSA
signature. It must scale also to all NIST variants before my patch set
can land.
BR, Jarkko
next prev parent reply other threads:[~2024-05-30 5:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 23:08 [PATCH 0/2] ecdsa: Use ecc_digits_from_bytes to simplify code Stefan Berger
2024-05-29 23:08 ` [PATCH 1/2] crypto: ecdsa - Use ecc_digits_from_bytes to create hash digits array Stefan Berger
2024-05-30 5:28 ` Jarkko Sakkinen
2024-05-30 12:24 ` Stefan Berger
2024-06-04 16:31 ` Jarkko Sakkinen
2024-05-29 23:08 ` [PATCH 2/2] crypto: ecdsa - Use ecc_digits_from_bytes to convert signature Stefan Berger
2024-05-30 5:28 ` Jarkko Sakkinen
2024-05-30 5:08 ` Jarkko Sakkinen [this message]
2024-05-30 12:16 ` [PATCH 0/2] ecdsa: Use ecc_digits_from_bytes to simplify code Stefan Berger
2024-06-04 16:30 ` Jarkko Sakkinen
2024-06-07 11:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1MPWI6C2ZCW.F08I9ILD63L4@kernel.org \
--to=jarkko@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox