From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305AbbJ1WgL (ORCPT ); Wed, 28 Oct 2015 18:36:11 -0400 Received: from mga01.intel.com ([192.55.52.88]:35100 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbJ1WgJ convert rfc822-to-8bit (ORCPT ); Wed, 28 Oct 2015 18:36:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,211,1444719600"; d="scan'208";a="837911875" From: "Dilger, Andreas" To: James Simmons , Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , "Drokin, Oleg" CC: James Simmons , Linux Kernel Mailing List , "lustre-devel@lists.lustre.org" Subject: Re: [lustre-devel] [PATCH 09/10] staging: lustre: fix remaining checkpatch issues for libcfs_hash.h Thread-Topic: [lustre-devel] [PATCH 09/10] staging: lustre: fix remaining checkpatch issues for libcfs_hash.h Thread-Index: AQHREdEJdjuMKYhX5kG//XQpJ56ypQ== Date: Wed, 28 Oct 2015 22:36:07 +0000 Message-ID: References: <1446051271-25189-1-git-send-email-jsimmons@infradead.org> <1446051271-25189-10-git-send-email-jsimmons@infradead.org> In-Reply-To: <1446051271-25189-10-git-send-email-jsimmons@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.113.75] Content-Type: text/plain; charset="us-ascii" Content-ID: <8CE35A9633F86F4E841184E9A47B51B5@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/28, 10:54, "lustre-devel on behalf of James Simmons" wrote: >From: James Simmons > >Final cleanup to make libcfs_hash.h completely kernel standard >compliant. > >Signed-off-by: James Simmons >--- > .../lustre/include/linux/libcfs/libcfs_hash.h | 16 >++++++++++------ > 1 files changed, 10 insertions(+), 6 deletions(-) > >diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h >b/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h >index 5df8ba2..563b2b4 100644 >--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h >+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h >@@ -62,7 +62,8 @@ > /** disable debug */ > #define CFS_HASH_DEBUG_NONE 0 > /** record hash depth and output to console when it's too deep, >- * computing overhead is low but consume more memory */ >+ * computing overhead is low but consume more memory >+ */ Typically, multi-line comments have the leading /* on a separate line from the first line of text. If you are changing all these comments you may as well make it consistent with the kernel style. Cheers, Andreas > #define CFS_HASH_DEBUG_1 1 > /** expensive, check key validation */ > #define CFS_HASH_DEBUG_2 2 >@@ -158,7 +159,8 @@ enum cfs_hash_tag { > */ > CFS_HASH_NBLK_CHANGE = 1 << 13, > /** NB, we typed hs_flags as __u16, please change it >- * if you need to extend >=16 flags */ >+ * if you need to extend >=16 flags >+ */ > }; > > /** most used attributes */ >@@ -206,7 +208,8 @@ enum cfs_hash_tag { > > struct cfs_hash { > /** serialize with rehash, or serialize all operations if >- * the hash-table has CFS_HASH_NO_BKTLOCK */ >+ * the hash-table has CFS_HASH_NO_BKTLOCK >+ */ > union cfs_hash_lock hs_lock; > /** hash operations */ > struct cfs_hash_ops *hs_ops; >@@ -375,7 +378,8 @@ cfs_hash_with_no_itemref(struct cfs_hash *hs) > { > /* hash-table doesn't keep refcount on item, > * item can't be removed from hash unless it's >- * ZERO refcount */ >+ * ZERO refcount. >+ */ > return (hs->hs_flags & CFS_HASH_NO_ITEMREF) != 0; > } > >@@ -820,7 +824,7 @@ cfs_hash_djb2_hash(const void *key, size_t size, >unsigned mask) > { > unsigned i, hash = 5381; > >- LASSERT(key != NULL); >+ LASSERT(key); > > for (i = 0; i < size; i++) > hash = hash * 33 + ((char *)key)[i]; >@@ -848,7 +852,7 @@ cfs_hash_u64_hash(const __u64 key, unsigned mask) > > /** iterate over all buckets in @bds (array of struct cfs_hash_bd) */ > #define cfs_hash_for_each_bd(bds, n, i) \ >- for (i = 0; i < n && (bds)[i].bd_bucket != NULL; i++) >+ for (i = 0; i < n && (bds)[i].bd_bucket; i++) > > /** iterate over all buckets of @hs */ > #define cfs_hash_for_each_bucket(hs, bd, pos) \ >-- >1.7.1 > >_______________________________________________ >lustre-devel mailing list >lustre-devel@lists.lustre.org >http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org > Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division