Re: [PATCH] tpm: Move dereference after NULL check in tpm_buf_check_hmac_response

Markus Elfring
2024-07-09T06:06:40Z

> We shouldn't dereference "auth" until after we have checked that it is
> non-NULL.

How do you think about to improve such a change description with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n94

> Fixes: 7ca110f2679b ("tpm: Address !chip->auth in tpm_buf_append_hmac_session*()")

1. Would the commit 1085b8276bb4239daa7008f0dcd5c973e4bd690f ("tpm:
Add the rest of the session HMAC API") be more appropriate as a reference?

2. Would you like to add a “stable tag” accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.10-rc7#n34

3. How do you think about to append parentheses to a function name
in the summary phrase?

Regards,
Markus