Re: [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags

Jarkko Sakkinen
2024-08-15T18:29:45Z

On Mon Aug 12, 2024 at 11:12 AM EEST, Dmitrii Kuvaiskii wrote:
> On Wed, Jul 17, 2024 at 01:36:08PM +0300, Jarkko Sakkinen wrote:
> > On Fri Jul 5, 2024 at 10:45 AM EEST, Dmitrii Kuvaiskii wrote:
> > > SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being
> > > reclaimed (moved to the backing store). This flag however has two
> > > logical meanings:
> > ~~~~~~~~
> > side-effects
>
> Could you clarify the required action here? Do you expect me to replace
> "This flag however has two logical meanings" with "This flag however has
> two logical side-effects"? The suggested word doesn't seem to apply nicely
> to this case. In my text, I have the following two sentences: "Don't
> attempt to load the enclave page" and "Don't attempt to remove the PCMD
> page ...". I don't think it's proper English to say that "Don't attempt
> ..." is a side effect. Or do you want me to also modify the two sentences
> in the list?

I agree with you here, you can ignore this comment.

BR, Jarkko