Re: [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags

Haitao Huang
2024-07-10T15:15:07Z

On Fri, 05 Jul 2024 02:45:22 -0500, Dmitrii Kuvaiskii
<dmitrii.kuvaiskii@intel.com> wrote:

> SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being
> reclaimed (moved to the backing store). This flag however has two
> logical meanings:
>
> 1. Don't attempt to load the enclave page (the page is busy).
> 2. Don't attempt to remove the PCMD page corresponding to this enclave
> page (the PCMD page is busy).
>
> To reflect these two meanings, split SGX_ENCL_PAGE_BEING_RECLAIMED into
> two flags: SGX_ENCL_PAGE_BUSY and SGX_ENCL_PAGE_PCMD_BUSY. Currently,
> both flags are set only when the enclave page is being reclaimed. A
> future commit will introduce a new case when the enclave page is being
> removed; this new case will set only the SGX_ENCL_PAGE_BUSY flag.
>
LGTM.
Reviewed-by: Haitao Huang <haitao.huang@linux.intel.com>
Thanks
Haitao