Re: [PATCH RFC 1/5] dt-bindings: iio: adc: add ADI ad4030 and ad4630

Conor Dooley
2024-06-28T16:55:36Z

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

On Thu, Jun 27, 2024 at 01:59:12PM +0200, Esteban Blanc wrote:
> This adds a binding specification for the Analog Devices Inc. AD4030 and
> AD4630 families of ADCs.
>
> Signed-off-by: Esteban Blanc <eblanc@baylibre.com>
> ---
> .../devicetree/bindings/iio/adc/adi,ad4030.yaml | 113 +++++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 121 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml
> new file mode 100644
> index 000000000000..7957c0c0ac7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2024 Analog Devices Inc.
> +# Copyright 2024 BayLibre, SAS.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad4030.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD4030 and AD4630 ADC family device driver
> +
> +maintainers:
> + - Nuno Sa <nuno.sa@analog.com>
> + - Michael Hennerich <michael.hennerich@analog.com>
> +
> +description: |
> + Analog Devices AD4030 single channel and AD4630 dual channel precision SAR ADC
> + family
> +
> + * https://www.analog.com/media/en/technical-documentation/data-sheets/ad4030-24-4032-24.pdf
> + * https://www.analog.com/media/en/technical-documentation/data-sheets/ad4630-24_ad4632-24.pdf
> + * https://www.analog.com/media/en/technical-documentation/data-sheets/ad4630-16-4632-16.pdf
> +
> +properties:
> +
> + compatible:
> + enum:
> + - adi,ad4030-24
> + - adi,ad4630-16
> + - adi,ad4630-24
> + - adi,ad4632-16
> + - adi,ad4632-24

I think this binding is fine, but I'd appreciate a note in the commit
message that mentions why these devices are not compatible. I presume it
is because the 16 and 24 denote how many bits there are and the number
of channels vary, but why the 4632-16 and 4630-16 aren't isn't as clear.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]