Re: [PATCH 1/2] Freescale MPC52xx support for 2.6 - Base part

[Kumar Gala <kumar.gala@freescale.com>]

On Jul 8, 2004, at 7:30 PM, Sylvain Munaut wrote:

> Kumar Gala wrote:
>
> > A few comments:
> >
> > cputable.c: * the 8280/52xx, maybe we should just have G2_LE, (same
> > core exists in 8272, 8249, etc.)
>
> IMHO, yes it may be better.

> > mpc52xx_setup.c: * what is cpu_52xx[]?
>
> A table with coefficients taken from datasheet. They're used to
> compute the core frequency according to XLB bus frequency and external
> jumper configurations.

Mind adding the above as a comment in the code.  :)

> > ppcboot.h: * was bi_immr_base not sufficient?
>
> I suppose your question is why create bi_mbar_base instead of using 
> immr.
> Well, I guess that would work just fine. The structure is just taken 
> straight from U-Boot sources.

Yes that was what I was asking about, and fair enough if we are 
mirroring the u-boot structure.  One of these days we will clean all of 
that up.

- kumar