public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
	"Dmitrii Kuvaiskii" <dmitrii.kuvaiskii@intel.com>
Cc: <dave.hansen@linux.intel.com>, <haitao.huang@linux.intel.com>,
	<kai.huang@intel.com>, <kailun.qin@intel.com>,
	<linux-kernel@vger.kernel.org>, <linux-sgx@vger.kernel.org>,
	<mona.vij@intel.com>, <reinette.chatre@intel.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] x86/sgx: Resolve EREMOVE page vs EAUG page data race
Date: Thu, 15 Aug 2024 21:37:15 +0300	[thread overview]
Message-ID: <D3GPBS12YXTZ.3M7RZ3EGDHN8E@kernel.org> (raw)
In-Reply-To: <D3GP9N3N7TUE.38H37K436OD50@kernel.org>

On Thu Aug 15, 2024 at 9:34 PM EEST, Jarkko Sakkinen wrote:
> On Mon Aug 12, 2024 at 11:25 AM EEST, Dmitrii Kuvaiskii wrote:
> > On Wed, Jul 17, 2024 at 01:38:59PM +0300, Jarkko Sakkinen wrote:
> >
> > > Ditto.
> >
> > Just to be sure: I assume this means "Fixes should be in the head of the
> > series so please reorder"? If yes, please see my reply in the other email
> > [1].
>
> OK, based on your earlier remarks and references I agree with you.
>
> >
> > [1] https://lore.kernel.org/all/20240812082128.3084051-1-dmitrii.kuvaiskii@intel.com/
> >
> > --
> > Dmitrii Kuvaiskii
>
> I think for future and since we have bunch of state flags, removing
> that "e.g." is worth of doing. Often you need to go through all of
> the flags to remind you how they interact, and at that point "one
> vs many" does help navigating the complexity.

Actually every time there's a patch that has anything to do with
the state flags I go through all  of em as a reminder. Might seem
like irrelevant detail but really is not (and neither unnecessarry
nitpicking). All small clues speed up that process or can mislead.

BR, Jarkko

  reply	other threads:[~2024-08-15 18:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  7:45 [PATCH v4 0/3] x86/sgx: Fix two data races in EAUG/EREMOVE flows Dmitrii Kuvaiskii
2024-07-05  7:45 ` [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags Dmitrii Kuvaiskii
2024-07-10 15:15   ` Haitao Huang
2024-07-17 10:36   ` Jarkko Sakkinen
2024-08-12  8:12     ` Dmitrii Kuvaiskii
2024-08-15 18:29       ` Jarkko Sakkinen
2024-07-17 10:37   ` Jarkko Sakkinen
2024-08-12  8:16     ` Dmitrii Kuvaiskii
2024-08-15 18:30       ` Jarkko Sakkinen
2024-07-25  2:00   ` Huang, Kai
2024-07-05  7:45 ` [PATCH v4 2/3] x86/sgx: Resolve EAUG race where losing thread returns SIGBUS Dmitrii Kuvaiskii
2024-07-17 10:38   ` Jarkko Sakkinen
2024-08-12  8:21     ` Dmitrii Kuvaiskii
2024-08-15 18:31       ` Jarkko Sakkinen
2024-07-25  0:52   ` Huang, Kai
2024-07-05  7:45 ` [PATCH v4 3/3] x86/sgx: Resolve EREMOVE page vs EAUG page data race Dmitrii Kuvaiskii
2024-07-10 15:16   ` Haitao Huang
2024-07-17 10:38   ` Jarkko Sakkinen
2024-08-12  8:25     ` Dmitrii Kuvaiskii
2024-08-15 18:34       ` Jarkko Sakkinen
2024-08-15 18:37         ` Jarkko Sakkinen [this message]
2024-07-25  1:21   ` Huang, Kai
2024-08-09  9:35     ` Dmitrii Kuvaiskii
2024-08-09 11:19       ` Huang, Kai
2024-08-12  8:32         ` Dmitrii Kuvaiskii
2024-08-12 10:34           ` Huang, Kai
2024-07-05  9:03 ` [PATCH v4 0/3] x86/sgx: Fix two data races in EAUG/EREMOVE flows Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D3GPBS12YXTZ.3M7RZ3EGDHN8E@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dmitrii.kuvaiskii@intel.com \
    --cc=haitao.huang@linux.intel.com \
    --cc=kai.huang@intel.com \
    --cc=kailun.qin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mona.vij@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox