From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 068C41547E6 for ; Sun, 18 Aug 2024 20:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724013007; cv=none; b=PaRzf52nkMt2xutS++0+Rj4u8JRIeTgB0AVcbK7p0nmYMZe+CXLA3LIJd/Q9QTQe4oEUoymhyIs8FUsqhu9jeSgQsRJCPr/cZ5CSpJ5/LojFjp22I6eb5sLWWxoj6jJQQtHBzodHBAMrhaQ2LbgJF2iob/7qcHWNmS0McHAeQzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724013007; c=relaxed/simple; bh=kIUPODz3cbQ5gt+8r9evwbR04C/aEv/J2gHXEvX3crA=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=T8mGyKzfuXVM4Lzg93VTxvQyZ9OVw79d+TwzP+ZK6VZ8Xyhhm9KDkZ8ioc7oyJpoH8SBQ3k6aFVtK4LOr3uUVaGD3wm9+JFzG2dkhD/FR5WSPOwGBSPsOcYJHiu+Cwb70ua+u7xPV3vGwNzUp7dgf+vflGc+q0NA7R++TqYXwJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=a46S0UYp; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="a46S0UYp" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-428ec6c190eso30454845e9.1 for ; Sun, 18 Aug 2024 13:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1724013003; x=1724617803; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BKuSjcunVmOP4VZx33TMXhdaxHVXIr/vpkFcjKrBzpY=; b=a46S0UYpmonx/q9TaFzkBHbQXj1ecnM8WhiAhDs72Dv3Oy87Iz36/rFHqjpnZ3OKTQ H14R6091zId0K0JLYDcXTvuHZ+Q62sdJAG0s1dGEcy17AQ2rUOxG+b1F1idWH+PcTJNq ySk8O3+C7kewo+IXaJm/I7sO8JHH6fCRhYiPgQNYOIXsKPlqAz6Rk6AlcBHeQD5ZjUmb xtNfuqU2USDkws4npkahh0R/Eq8y8YS+3nx9Tq7h17gqCli9Frzvvl6efmWsmm7Srmk2 ctCa/lpe3lh2SDZGAUlebZx0LbLONYle6zwMMdLAM5K6HR/oyIgjQQUVaPNtAVzTC6rd wYxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724013003; x=1724617803; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BKuSjcunVmOP4VZx33TMXhdaxHVXIr/vpkFcjKrBzpY=; b=jyDFdfw3prOLekw8tZqrURXJjJ3iLnhnsNZSwEK/FveqvuVrpjllt0g5LVATwORpVR ldSk7F5OeBTB7bhBn1ZDDT7v8fVhgaalPvHTK8vbOeBzXOGibX33tHLhxKAduqjUqtB8 xL1/vavKL4LtDYolSB7umlLJYpQfkr7swOvJD+O9LywTEkbD6G0ravtkFED5FPaxxDMB zA48ueLlcjGjzSoSFC1+7epgx1yQcFgdh0aOvM8fxEmoYIsOgTmlfptZznY8zXdJ7NY+ mEEAQDtWgooX9l+VuXOlXmMJ7B263pn5pE4N6vpCIsHQy8NSnAlEzbu8lz8KVB5gfqAD Z4hA== X-Forwarded-Encrypted: i=1; AJvYcCVyjUWavMAQM0i6MFZR2U5pER2L/8Ex329k2p5DUagY7VmPVvtw9pcMOHY+BDcaC3tPE5OQwHeBeQpS5xftFqyu9oW9YEmftl4mJQ20 X-Gm-Message-State: AOJu0YxAzfsC9lwtebG768hnkjWZrTLC8+xmo7x430nfesvG1VF1fDsJ qAq7t8JtzVzyVoQxMnZT59AnwrwAEAoNJju9Wm+13rp/fkbS1Mbr1LfgUQmF8Xs= X-Google-Smtp-Source: AGHT+IGdjsfegB8yke+aoiRcnbr1T/5MJGCjCQl1jxLBjE8tUqmY1ED2da6ecMdVTHRwtGSIHNZ+CA== X-Received: by 2002:a05:600c:1e15:b0:426:5b21:9801 with SMTP id 5b1f17b1804b1-42aa826510fmr31755565e9.27.1724013003127; Sun, 18 Aug 2024 13:30:03 -0700 (PDT) Received: from localhost (ip-185-104-138-79.ptr.icomera.net. [185.104.138.79]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded72524sm142052615e9.34.2024.08.18.13.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Aug 2024 13:30:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 18 Aug 2024 22:30:00 +0200 Message-Id: From: "Luca Weiss" To: "Luca Weiss" , "Heikki Krogerus" , "Greg Kroah-Hartman" , "Konrad Dybcio" , "Dmitry Baryshkov" , "Caleb Connolly" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH] usb: typec: fsa4480: Relax CHIP_ID check X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20240818-fsa4480-chipid-fix-v1-1-17c239435cf7@fairphone.com> In-Reply-To: <20240818-fsa4480-chipid-fix-v1-1-17c239435cf7@fairphone.com> On Sun Aug 18, 2024 at 10:21 PM CEST, Luca Weiss wrote: > Some FSA4480-compatible chips like the OCP96011 used on Fairphone 5 > return 0x00 from the CHIP_ID register. Handle that gracefully and only > fail probe when the I2C read has failed. > > With this the dev_dbg will print 0 but otherwise continue working. > > [ 0.251581] fsa4480 1-0042: Found FSA4480 v0.0 (Vendor ID =3D 0) Short appendix: just checked the OCP96011 datasheet and it does mention register 00H being "Device ID" and "Reset Value" being 0x00 so that's expected behavior on this specific chip. Regards Luca > > Cc: stable@vger.kernel.org > Fixes: e885f5f1f2b4 ("usb: typec: fsa4480: Check if the chip is really th= ere") > Signed-off-by: Luca Weiss > --- > drivers/usb/typec/mux/fsa4480.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux/fsa4480.c b/drivers/usb/typec/mux/fsa4= 480.c > index cd235339834b..f71dba8bf07c 100644 > --- a/drivers/usb/typec/mux/fsa4480.c > +++ b/drivers/usb/typec/mux/fsa4480.c > @@ -274,7 +274,7 @@ static int fsa4480_probe(struct i2c_client *client) > return dev_err_probe(dev, PTR_ERR(fsa->regmap), "failed to initialize = regmap\n"); > =20 > ret =3D regmap_read(fsa->regmap, FSA4480_DEVICE_ID, &val); > - if (ret || !val) > + if (ret) > return dev_err_probe(dev, -ENODEV, "FSA4480 not found\n"); > =20 > dev_dbg(dev, "Found FSA4480 v%lu.%lu (Vendor ID =3D %lu)\n", > > --- > base-commit: ccdbf91fdf5a71881ef32b41797382c4edd6f670 > change-id: 20240818-fsa4480-chipid-fix-2c7cf5810135 > > Best regards,