From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D02A19C568 for ; Thu, 5 Sep 2024 12:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725538886; cv=none; b=MZID4pZ9QZnDI+dhw+SCd07K2OTGRJSwPLSOxn69Uos3gB93BjHZ98UGkV0AKienNgWvjZoOUeO1MPWdE9u/bjakQ8LAd/3BIDc6T0IAwDB0H7jOtKiK/kpOz1oxApPoIW9QJWMcuv66qF0ZlvorI6EflLtdTixicFcdZCxv44o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725538886; c=relaxed/simple; bh=a30qVaCjRBhA+CrZpyQ5LQoff0lBw1ghBzVO6+FMHXU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=bt/4miTDF5QJ7+FpLMROmdpfyo/awfJKSTv1dsip/Y7fek52GWkBWO8ku8ZbpMQt3vmyo0Qs8a0cgdMXjZieCmjc1bK+49LqT9h2fF71hTjfFOzz8b6jCoGtE0j65aJH+gGAxDqDe5jdM7iLu0Fk+AaPKclStUZHmFH/rE1KPBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=zp8p7HP3; arc=none smtp.client-ip=95.215.58.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="zp8p7HP3" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1725538881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m0upCeZNrvDUQnDPHLYGuminqK/9oN+kaTuNQFta8ZQ=; b=zp8p7HP3ol+AN7+2w0u8sw3feRS6+EtQvIxCq07dq9Dksj1BTJW2+cqNyFjtKP6ganjaEn yRNrdKSMcY/zfUd8lPaFdyuO200HIfl9M0UYYVq+QjhfTeeHWi3ZsXLlJI/TiAsATCV/lL veM7whyuJj/XoEN2jpV4SpdNDhvZug15hXJg+oub6sWMNS2+cB/OUt0lAoVp2pFnJ7qL2j SqaBjowIo9rVkcQwbGsTr0xQhJHz0c8SGtIc0svjbcOf+GIlorwOBqTw4aNVmdWlAEsRFN ylbUhCkexhSvxeUXkNtWjgLL7n/y9GT0QxkzY2rzCRTpBPMhUMgjMPRxu1j2AA== Content-Type: multipart/signed; boundary=2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Thu, 05 Sep 2024 14:21:12 +0200 Message-Id: Cc: , , , , , , Subject: Re: [PATCH] arm64: dts: rockchip: Add a few aliases to the PineTab2 dtsi X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Krzysztof Kozlowski" , "Dragan Simic" , References: <987e68d1c5e9a0cc56d730aec87246aa5ab8ea14.1725535770.git.dsimic@manjaro.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT --2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Thu Sep 5, 2024 at 1:39 PM CEST, Krzysztof Kozlowski wrote: > On 05/09/2024 13:32, Dragan Simic wrote: > > Sprinkle a few commonly used aliases onto the PineTab2 dtsi file, to im= prove > > its readability a bit, to make it easier to refer to the actual nodes l= ater, > > if needed, and to add a bit more detail to some of the labels. > >=20 > > Suggested-by: Diederik de Haas > > Signed-off-by: Dragan Simic > > Unused aliases do not improve readability, so for me this change is > making code worse without valid reason. This came forth by a question from me to Dragan about a patch for another board which doesn't have a charger defined at all (yet). I actually have that patch (but not the HW) for a while (~1.5 year) now and I had used `rk817_charger: charger` for that, probably because I saw that being used everywhere else. Then I compared it to the PineTab2 and noticed it had only `charger`, so I asked "What should I use? With or without the alias?" In this case the inconsistency is causing confusion (with me). So: What should be used for that other/new board(s)? Cheers, Diederik --2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZtmiOgAKCRDXblvOeH7b bivAAQChtRQ4JLxi+OzTHCGMxlshCxBB/+x9r0QIrUHdVfc2oAD/W0i0uuf14sm/ WIQpeeE4yYyvBIzmSAeyyCQ1XcoRYgw= =dEN9 -----END PGP SIGNATURE----- --2d312f426b36611740239ff3b0c317c3ffbb2d79eaae2fd1cbf4292c25aa--