Re: [PATCH 07/19] rust: enable `clippy::ignored_unit_patterns` lint

Alice Ryhl
2024-09-05T08:08:43Z

On Wed, Sep 4, 2024 at 10:45 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> In Rust 1.73.0, Clippy introduced the `ignored_unit_patterns` lint [1]:
>
> > Matching with `()` explicitly instead of `_` outlines the fact that
> > the pattern contains no data. Also it would detect a type change
> > that `_` would ignore.
>
> There is only a single case that requires a change:
>
> error: matching over `()` is more explicit
> --> rust/kernel/types.rs:176:45
> |
> 176 | ScopeGuard::new_with_data((), move |_| cleanup())
> | ^ help: use `()` instead of `_`: `()`
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
> = note: requested on the command line with `-D clippy::ignored-unit-patterns`
>
> Thus clean it up and enable the lint -- no functional change intended.
>
> Link: https://rust-lang.github.io/rust-clippy/master/index.html#/ignored_unit_patterns [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>