From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbaIVTdi (ORCPT ); Mon, 22 Sep 2014 15:33:38 -0400 Received: from mga09.intel.com ([134.134.136.24]:7890 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbaIVTdg (ORCPT ); Mon, 22 Sep 2014 15:33:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,573,1406617200"; d="asc'?scan'208";a="606743683" From: "Rustad, Mark D" To: Peter Zijlstra CC: "sparse@chrisli.org" , "linux-kernel@vger.kernel.org" , "richard.weinberger@gmail.com" , "linux-sparse@vger.kernel.org" , "mingo@redhat.com" , "Kirsher, Jeffrey T" , "computersforpeace@gmail.com" Subject: Re: [PATCH] sched: Remove nested extern Thread-Topic: [PATCH] sched: Remove nested extern Thread-Index: AQHP1o5n4j/Km9jR6U6Rx5Rq0DoBGpwN93YAgAAIi4A= Date: Mon, 22 Sep 2014 19:32:04 +0000 Message-ID: References: <20140922175511.62229.98784.stgit@mdrustad-wks.jf.intel.com> <20140922190128.GA2805@worktop.programming.kicks-ass.net> In-Reply-To: <20140922190128.GA2805@worktop.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [134.134.176.145] Content-Type: multipart/signed; boundary="Apple-Mail=_8CCC8EA9-24BF-4637-A31E-5A11B69304C9"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_8CCC8EA9-24BF-4637-A31E-5A11B69304C9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 22, 2014, at 12:01 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: >> Avoid W=2 nested-externs warning by moving the nested extern to >> a normal extern. This eliminates that warning which is generated >> for every inclusion of sched.h in a kernel build when W=2 is used. >> This also removes a point of maintenance if the definition of >> delayacct_on were ever to change. > > Yeah, so why is that warning worth using? Just disable the warn if > you're bothered by it. I assume that nested-externs is included in W=2 because many uses of them, especially with function prototypes, creates a risk of inconsistent declarations. The kernel has a fair number of them that seem to have been added to disentangle include files. If they are judged to be worthwhile, then it would be good to silence the warnings so that attention can be given to other instances of the warnings. If those nested externs are not worth the risk, well that is a different conversation. -- Mark Rustad, Networking Division, Intel Corporation --Apple-Mail=_8CCC8EA9-24BF-4637-A31E-5A11B69304C9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJUIHkzAAoJEDwO/+eO4+5u45wP/11SArEWtpADJbQnAfcGPBR3 qlryiWpF9e5hqj55QFSFIcg+Ff9KxGKo0tq2ZwxAY4oA+46J09TuvsAtEzHrIo+v My+e5l9ToMbEk7/PjUGVw/Xl/0pgFMQ50trPkHQyG0VJezjKfJAzM2TKmJCqYpt8 croy6C9spXlajEcLnN67XWgUsAz02y+m/kKwZEpYQKzqg+aaC7Qm811AgxXdFZ0y Oft1t+DmA+RQXi1Dgn6jI3LPlH02Y10fiubSbAe2uEAvcj9A4lqXli9PIe37Rr3o urSTWwWgidMz43ZHAznRZIknTXOKQq9l8O7JqvejfOEP9J/HsD9Yg5/Xmo5Wvgm+ 5QGKjtTqcEH2zG4vhAmHxkwOjPQwaDZTrEiWraacrlFp1znfW2U43qzMqcPQ0vme 2khFZdfaZI2jqi80BMb6sYuYdO36kV5UKilCfGjo3NNjZvXt/rzey2nSHXhvLFS4 kPINyajdqp8k1UBOW/902WST5ljWipdaV2QAfsLC7QH372Gc+f8A/08xv8xio+Uc Frmmy4Kk2VjdSgJcAdUoJwD2YLUnFBXEcIrUO546xsu/ELLfAGTXcCcSbcp2pksX WrKdJNGbebB707ezrVc6Tq3lrft2qX7JJ2/rXaSMOFNPdr1BmDhO39aliiPSynGZ 0PSiRgJwmg1v/hQBOA7Z =B3pP -----END PGP SIGNATURE----- --Apple-Mail=_8CCC8EA9-24BF-4637-A31E-5A11B69304C9--