From: Ben Evans <bevans@cray.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>, Ben Evans <bevans@cray.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move
Date: Mon, 12 Dec 2016 14:42:29 +0000 [thread overview]
Message-ID: <D474211B.C0F0%jevans@cray.com> (raw)
In-Reply-To: <20161210181433.GA8477@kroah.com>
This was done to conform to the Lustre Coding Guidelines.
-Ben
On 12/10/16, 1:14 PM, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
wrote:
>On Sat, Dec 10, 2016 at 01:05:59PM -0500, James Simmons wrote:
>> From: Ben Evans <bevans@cray.com>
>>
>> It was found if you sort the headers alphabetically
>> that it reduced patch conflicts. This patch sorts
>> the headers alphabetically and also place linux
>> header first, then uapi header and finally the
>> lustre kernel headers.
>
>I still don't agree, when did you last have a patch conflict with this
>file in the .h section? And exactly how hard was it to fix it up?
>
>I'm all for cleanups, but really, this is useless. And I said so the
>last time you sent it...
>
>greg k-h
next prev parent reply other threads:[~2016-12-12 14:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 18:05 [PATCH v2 0/5] Fix ups to make lustre_idl.h a proper UAPI header James Simmons
2016-12-10 18:05 ` [PATCH v2 1/5] staging: lustre: obdclass: Create a header for obdo related functions James Simmons
2016-12-10 18:05 ` [PATCH v2 2/5] staging: lustre: obdclass: style cleanup " James Simmons
2016-12-10 18:05 ` [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move James Simmons
2016-12-10 18:14 ` Greg Kroah-Hartman
2016-12-12 14:42 ` Ben Evans [this message]
2016-12-12 16:34 ` Greg Kroah-Hartman
2016-12-12 18:12 ` Ben Evans
2016-12-12 18:19 ` Joe Perches
2016-12-12 19:41 ` James Simmons
2016-12-12 19:52 ` Joe Perches
2016-12-10 18:06 ` [PATCH v2 4/5] staging: lustre: headers: Move functions out of lustre_idl.h James Simmons
2016-12-10 18:06 ` [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons
2016-12-10 18:16 ` Greg Kroah-Hartman
2016-12-12 20:00 ` James Simmons
2016-12-13 0:37 ` Greg Kroah-Hartman
2016-12-13 8:31 ` Dan Carpenter
2016-12-13 16:14 ` Oleg Drokin
2016-12-13 17:21 ` Dan Carpenter
2016-12-13 0:55 ` Dilger, Andreas
2016-12-13 1:07 ` Greg Kroah-Hartman
2016-12-19 17:02 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D474211B.C0F0%jevans@cray.com \
--to=bevans@cray.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox