From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jan Stancek" <jstancek@redhat.com>,
"Jarkko Sakkinen" <jarkko.sakkinen@iki.fi>
Cc: "Neal Gompa" <neal@gompa.dev>,
"David Howells" <dhowells@redhat.com>, <dwmw2@infradead.org>,
<zxu@redhat.com>, <keyrings@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Asahi Linux" <asahi@lists.linux.dev>,
"Hector Martin" <marcan@marcan.st>, "Janne Grunau" <j@jannau.net>
Subject: Re: [PATCH 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0
Date: Sat, 21 Sep 2024 01:16:46 +0300 [thread overview]
Message-ID: <D4BGJGUL3HSW.19HZANGB06JSW@kernel.org> (raw)
In-Reply-To: <CAASaF6zhiDdbfYkgg7wENih2Lp309eUgeu=FHZm0yYaEBt2gRg@mail.gmail.com>
On Fri Sep 20, 2024 at 11:05 PM EEST, Jan Stancek wrote:
> This looks like false-positive. Following will produce same error:
> +#if TEST
> + ENGINE *e;
> +#endif
> +
> $ git diff > 1.patch; ./scripts/checkpatch.pl 1.patch
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #10: FILE: scripts/sign-file.c:217:
> + ENGINE *e;
> ^
>
> total: 1 errors, 0 warnings, 10 lines checked
>
> but if first type in #if block is something checkpatch recognizes,
> then it reports no issues:
> +#if TEST
> + int i;
> + ENGINE *e;
> +#endif
> +
>
> $ git diff > 1.patch; ./scripts/checkpatch.pl 1.patch
> total: 0 errors, 0 warnings, 11 lines checked
I fixed a couple of alignment issues reported by "checkpatch.pl
--strict" and sent a pull request:
https://lore.kernel.org/keyrings/D4B9WXZC9B9U.34I6BHWMYXOS2@kernel.org/T/#u
> Regards,
> Jan
BR, Jarkko
next prev parent reply other threads:[~2024-09-20 22:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 7:11 [PATCH 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0 Jan Stancek
2024-07-12 7:11 ` [PATCH 1/3] sign-file,extract-cert: move common SSL helper functions to a header Jan Stancek
2024-08-13 10:04 ` Jarkko Sakkinen
2024-07-12 7:11 ` [PATCH 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line() Jan Stancek
2024-08-13 10:12 ` Jarkko Sakkinen
2024-07-12 7:11 ` [PATCH 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 Jan Stancek
2024-08-13 10:23 ` Jarkko Sakkinen
2024-08-02 13:10 ` [PATCH 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0 Herbert Xu
2024-08-02 17:59 ` Jarkko Sakkinen
2024-08-02 18:27 ` Jan Stancek
2024-08-02 19:54 ` Jarkko Sakkinen
2024-08-06 20:27 ` Neal Gompa
2024-09-20 11:42 ` Neal Gompa
2024-09-20 15:34 ` Jarkko Sakkinen
2024-09-20 20:05 ` Jan Stancek
2024-09-20 22:16 ` Jarkko Sakkinen [this message]
2024-09-03 8:11 ` R Nageswara Sastry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4BGJGUL3HSW.19HZANGB06JSW@kernel.org \
--to=jarkko@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=j@jannau.net \
--cc=jarkko.sakkinen@iki.fi \
--cc=jstancek@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=zxu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox