From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, adam@yggdrasil.com
Subject: Re: [PATCH] Proposed module init race fix.
Date: Wed, 15 Jan 2003 15:21:22 +0100 [thread overview]
Message-ID: <D4E37953801@vcnet.vc.cvut.cz> (raw)
On 15 Jan 03 at 20:06, Rusty Russell wrote:
> In message <200301150846.AAA01104@adam.yggdrasil.com> you write:
> > On 2003-01-15, Rusty Russell wrote:
> > >It's possible to start using a module, and then have it fail
> > >initialization. In 2.4, this resulted in random behaviour. One
> > >solution to this is to make all interfaces two-stage: reserve
> > >everything you need (which might fail), the activate them. This
> > >means changing about 1600 modules, and deprecating every interface
> > >they use.
> >
> > Could you explain this "random behavior" of 2.4 a bit more?
> > As far as I know, if a module's init function fails, it must
> > unregister everything that it has registered up to that point.
>
> And if someone's using it, the module gets unloaded underneath them.
No. Unregister will go to sleep until it is safe to unregister
driver. See unregister_netdevice for perfect example, but I'm sure
that there are other unregister functions which make sure that after
unregister it is OK to destroy everything.
Best regards,
Petr Vandrovec
vandrove@vc.cvut.cz
next reply other threads:[~2003-01-15 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 14:21 Petr Vandrovec [this message]
2003-01-16 1:48 ` [PATCH] Proposed module init race fix Rusty Russell
2003-01-16 2:55 ` Werner Almesberger
-- strict thread matches above, loose matches on Subject: below --
2003-01-15 8:46 Adam J. Richter
2003-01-15 9:06 ` Rusty Russell
2003-01-15 8:24 Rusty Russell
2003-01-15 16:34 ` Roman Zippel
2003-01-17 1:38 ` Rusty Russell
2003-01-17 15:35 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4E37953801@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox