Re: [PATCH v1 2/6] s390/uv: Retrieve UV secrets support

Janosch Frank
2024-10-02T07:51:33Z

On 10/1/24 6:06 PM, Christoph Schlameuss wrote:
> On Mon Sep 30, 2024 at 3:19 PM CEST, Steffen Eiden wrote:
>> Provide a kernel API to retrieve secrets from the UV secret store.
>> Add two new functions:
>> * `uv_get_secret_metadata` - get metadata for a given secret identifier
>> * `uv_retrieve_secret` - get the secret value for the secret index
>>
>> With those two functions one can extract the secret for a given secret
>> id, if the secret is retrievable.
>>
>> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
>> ---
>> arch/s390/include/asm/uv.h | 131 ++++++++++++++++++++++++++++++++++++-
>> arch/s390/kernel/uv.c | 124 +++++++++++++++++++++++++++++++++++
>> 2 files changed, 254 insertions(+), 1 deletion(-)
>
> [...]
>
>> /* Bits in installed uv calls */
>> enum uv_cmds_inst {
>> @@ -95,6 +96,7 @@ enum uv_cmds_inst {
>> BIT_UVC_CMD_ADD_SECRET = 29,
>> BIT_UVC_CMD_LIST_SECRETS = 30,
>> BIT_UVC_CMD_LOCK_SECRETS = 31,
>
> Is 32 skipped intentionally? Should there be a comment here that it is reserved?

Yes, we usually only add the things that are needed for a patch series.
32 is used for some other UVC which will be added in another series.

Also those bits are defined by architecture, not by KVM.