From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9A60157A6C for ; Wed, 2 Oct 2024 19:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727897930; cv=none; b=XZfXpkMh+SIBHZ+YIPDNaFqVj67uqNlIELcp21/LE5AGg9HqOl2SPDi05BEdPBv3JKaebgBIuRSNurjU6eegbPVmU6YiZN0T7TfUz0FG5LQobVNK0QFIAV/kqTYW1mDaw47E9Dn1yLWdHnvEIStbnWZRI8XHBv5DFGZm6hLCVIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727897930; c=relaxed/simple; bh=7l4uNnr3+4aRoL9CXECGDQ5tyLJ972XOIOkX3lCUt8c=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=HHsLUY9guFG2TI/U5sYx8qbfQM0UVL21iaJquOloM8RcI2qBbB7JFD82dARYn4mXY5pEgpBOktkDKZz6SlNF0g5KOnSZggCvMTXeowl/HbfWjg+9ggXLL0vCWRCQI5k24Yy+ziCpLdlgNhO9dlhaCPTiFg40ABa52LJM/jJIAIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=E8AN09Lm; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="E8AN09Lm" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1727897926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MAuXe0O3NSF994mavqo25iaQ8hQ/ha0f9ecg/g2gJWI=; b=E8AN09LmfqrysbmhydRjpjdsAn3biTkK8f9dWRaCXFbaShjmP3vdUvdh7+NI9HN+hum8Gf QY4b4gEe91QUQch3pkiuf+5JWq0gnLi8nlwXTxdy1sof7IPvY/6ozjTawKHjjm7tc7ulWi 2dQEeAtrJZzzPanAwI0ExrwkgT5QA/rAILkNY/XQ1hl0LxCMXAX6c8xbm7d96Tkfq5qVkb lRXY5+7z6zzycuieL5viwoCDFR/G4objF8+DhMmbWn7oE6My5nDatFoAurdN/zfYGt7HVi BPJ7jmdwrTrbde3C0l1ECyFc9Y7EC2xnJnpbv7v3A1cUV8aT0fx3REu9wFfJEw== Content-Type: multipart/signed; boundary=3a883e580afd625faf3965ca5225d4c2652f66b4a902790343c6692e64f8; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Wed, 02 Oct 2024 21:38:32 +0200 Message-Id: Subject: Re: [PATCH v2 00/10] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Laurent Pinchart" , "Jonas Karlman" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" Cc: "Diederik de Haas" , "Heiko Stuebner" , "Jernej Skrabec" , "Christian Hewitt" , "Christopher Obbard" , , , References: <20240908132823.3308029-1-jonas@kwiboo.se> In-Reply-To: X-Migadu-Flow: FLOW_OUT --3a883e580afd625faf3965ca5225d4c2652f66b4a902790343c6692e64f8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Jonas and Laurent, I may be showing my n00bness ... or I actually found something ... On Fri Sep 13, 2024 at 7:30 PM CEST, Diederik de Haas wrote: > On Sun Sep 8, 2024 at 3:28 PM CEST, Jonas Karlman wrote: > > This series ensure poweron/poweroff and CEC phys addr invalidation is > > happening under drm mode_config mutex lock, and also ensure EDID is > > updated (when the dw-hdmi connector is used) after a hotplug pulse. > > > > These changes has mainly been tested on Rockchip devices together with = a > > series [1] that add HDMI 2.0 4K@60Hz support to RK3228, RK3328, RK3399 > > and RK3568. > > I did some tests with this series (together with the 4K60Hz one). > > ... > > I then went on the HDMI-hot-plug-swap-test and connected it to my 1080p > monitor while the system was still online. That did not change the > output of the previous command. As my monitor doesn't support 4K it > seems to have chosen a 640p or 720p resolution. > IOW the letters were rather big. With enough output on the screen, it > went off the visible area, so all I could do then was 'blind' typing. > > If I booted up connected to the 1080p monitor then it reported a 1080p > resolution and when swapping to the 4K TV, it kept reporting that value > and displaying things in 1080p resolution, but ofc there were no > abnormal big letters or output falling off the screen this time. A DT validation on rk3328-rock64.dtb reported this: rockchip/rk3328-rock64.dtb: hdmi@ff3c0000: interrupts: [[0, 35, 4], [0, 71,= 4]] is too long That's because `display/bridge/synopsys,dw-hdmi.yaml` dt-binding has interrupts : maxItems : 1 and the rk3328.dtsi file has 2 interrupts in its hdmi node. Easiest solution is to just remove the 2nd one and that makes DT validation happy. Looking at the rk3328 TRM, I found these hdmi related interrupts: 67 hdmi_intr 103 hdmi_intr_wakeup Looking at the rk3399 TRM, I found these hdmi related interrupts: 23 hdmi_irq 24 hdmi_wakeup_irq Looking at the rk3568 TRM, I found these hdmi related interrupts: 76 hdmi_wakeup 77 hdmi So my thinking is: - what if the dt-binding is incorrect? (-> maxItems : 2?) - wakeup 'sounds like' Hot Plug Detection? which makes it relevant for this series and it could mean that the rk3399-base.dtsi and rk356x.dtsi are actually missing an interrupt definition in their DT files? Or I am completely talking nonsense, which is the most likely scenario. Cheers, Diederik --3a883e580afd625faf3965ca5225d4c2652f66b4a902790343c6692e64f8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZv2hPgAKCRDXblvOeH7b bmmrAQD2mW1+acc5OPHMteyhoxMRMFD4vmCP/MBBFkFjRlytFQD+IdxwUTVUb7/e RzIrjKLyw2w+vxRnrW5FZkj8vkS36QA= =SYHq -----END PGP SIGNATURE----- --3a883e580afd625faf3965ca5225d4c2652f66b4a902790343c6692e64f8--