From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: <x86@kernel.org>, "Ross Philipson" <ross.philipson@oracle.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"open list:TPM DEVICE DRIVER" <linux-integrity@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/4] Alternative TPM patches for Trenchboot
Date: Mon, 04 Nov 2024 13:29:00 +0200 [thread overview]
Message-ID: <D5DCY0MCPDC2.3C6FDTRKPFU8H@kernel.org> (raw)
In-Reply-To: <D5DCR279TZY5.1C7KRTFPGD3WU@kernel.org>
On Mon Nov 4, 2024 at 1:19 PM EET, Jarkko Sakkinen wrote:
> > I don't categorically reject adding some code to early setup. We have
> > some shared code EFI stub but you have to explain your changes
> > proeprly. Getting rejection in some early version to some approach,
> > and being still pissed about that years forward is not really way
> > to go IMHO.
>
> ... and ignoring fixes that took me almost one day to fully get together
> is neither.
>
> These address the awful commit messages, tpm_tis-only filtering and not
> allowing repetition in the calls.
Also considering early setup: it is not part of uapi. It can be
reconsidered after the feature is landed as improvement (perhaps
also easier to project then). I don't think TPM2_PolicyLocality
potential conflict is important for kernel, and that is the only
known race I know at this point.
I don't really get the problem here. It's almost I like I should
not have mentioned potential concurrency issue in order to not
get slandered.
BR, Jarkko
next prev parent reply other threads:[~2024-11-04 11:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 15:22 [RFC PATCH 0/4] Alternative TPM patches for Trenchboot Jarkko Sakkinen
2024-11-02 15:22 ` [RFC PATCH 1/4] tpm, tpm_tis: Close all localities Jarkko Sakkinen
2024-11-02 15:22 ` [RFC PATCH 2/4] tpm, tpm_tis: Address positive localities in tpm_tis_request_locality() Jarkko Sakkinen
2024-11-02 15:22 ` [RFC PATCH 3/4] tpm, tpm_tis: allow to set locality to a different value Jarkko Sakkinen
2024-11-02 15:22 ` [RFC PATCH 4/4] tpm: sysfs: Show locality used by kernel Jarkko Sakkinen
2024-11-02 18:00 ` [RFC PATCH 0/4] Alternative TPM patches for Trenchboot Jarkko Sakkinen
2024-11-04 10:57 ` Daniel P. Smith
2024-11-04 11:18 ` Jarkko Sakkinen
2024-11-04 11:19 ` Jarkko Sakkinen
2024-11-04 11:29 ` Jarkko Sakkinen [this message]
2024-11-04 11:27 ` Ard Biesheuvel
2024-11-04 11:47 ` Jarkko Sakkinen
2024-11-04 11:52 ` Daniel P. Smith
2024-11-04 11:55 ` Ard Biesheuvel
2024-11-04 12:06 ` Jarkko Sakkinen
2024-11-04 12:19 ` Daniel P. Smith
2024-11-04 13:21 ` James Bottomley
2024-11-04 16:34 ` Daniel P. Smith
2024-11-04 20:36 ` James Bottomley
2024-11-05 0:13 ` Daniel P. Smith
2024-11-04 15:03 ` Jarkko Sakkinen
2024-11-04 20:40 ` ross.philipson
2024-11-05 0:51 ` ross.philipson
2024-11-05 16:24 ` Ard Biesheuvel
2024-11-05 18:21 ` ross.philipson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5DCY0MCPDC2.3C6FDTRKPFU8H@kernel.org \
--to=jarkko@kernel.org \
--cc=ardb@kernel.org \
--cc=dpsmith@apertussolutions.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox