From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Abel Vesa" <abel.vesa@linaro.org>,
"Sibi Sankar" <quic_sibis@quicinc.com>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH PATCH RFT 15/19] arm64: dts: qcom: sm6350: Fix ADSP memory length
Date: Fri, 06 Dec 2024 16:55:42 +0100 [thread overview]
Message-ID: <D64QNNAMVMJM.3NDC6J100E8ME@fairphone.com> (raw)
In-Reply-To: <20241206-dts-qcom-cdsp-mpss-base-address-v1-15-2f349e4d5a63@linaro.org>
On Fri Dec 6, 2024 at 4:32 PM CET, Krzysztof Kozlowski wrote:
> The address space in ADSP (Peripheral Authentication Service) remoteproc
> node should point to the QDSP PUB address space (QDSP6...SS_PUB) which
> has a length of 0x10000.
>
> This should have no functional impact on Linux users, because PAS loader
> does not use this address space at all.
I can't verify this information, but with this change ADSP is still
starting up as expected:
Tested-by: Luca Weiss <luca.weiss@fairphone.com>
>
> Fixes: efc33c969f23 ("arm64: dts: qcom: sm6350: Add ADSP nodes")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 8d697280249fefcc62ab0848e949b5509deb32a6..3df506c2745ea27f956ef7d7a4b5fbaf6285c428 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -1283,7 +1283,7 @@ tcsr_mutex: hwlock@1f40000 {
>
> adsp: remoteproc@3000000 {
> compatible = "qcom,sm6350-adsp-pas";
> - reg = <0 0x03000000 0 0x100>;
> + reg = <0x0 0x03000000 0x0 0x10000>;
>
> interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
> <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
next prev parent reply other threads:[~2024-12-06 15:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 15:32 [PATCH 00/19] arm64: dts: qcom: Fix remoteproc memory base and length Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH 01/19] arm64: dts: qcom: sm8350: Fix ADSP " Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH 02/19] arm64: dts: qcom: sm8350: Fix CDSP " Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH 03/19] arm64: dts: qcom: sm8350: Fix MPSS memory length Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH 04/19] arm64: dts: qcom: sm8450: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-06 15:43 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH 05/19] arm64: dts: qcom: sm8450: Fix CDSP memory length Krzysztof Kozlowski
2024-12-06 15:43 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH 06/19] arm64: dts: qcom: sm8450: Fix MPSS " Krzysztof Kozlowski
2024-12-06 15:43 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH 07/19] arm64: dts: qcom: sm8550: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-06 15:43 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH 08/19] arm64: dts: qcom: sm8550: Fix CDSP memory length Krzysztof Kozlowski
2024-12-06 15:42 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH 09/19] arm64: dts: qcom: sm8550: Fix MPSS " Krzysztof Kozlowski
2024-12-06 15:42 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH PATCH RFT 10/19] arm64: dts: qcom: sm8650: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-06 15:40 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH PATCH RFT 11/19] arm64: dts: qcom: sm8650: Fix CDSP memory length Krzysztof Kozlowski
2024-12-06 15:42 ` Neil Armstrong
2024-12-09 10:51 ` Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH PATCH RFT 12/19] arm64: dts: qcom: sm8650: Fix MPSS " Krzysztof Kozlowski
2024-12-06 15:42 ` Neil Armstrong
2024-12-06 15:32 ` [PATCH 13/19] arm64: dts: qcom: x1e80100: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-06 15:49 ` Johan Hovold
2024-12-09 10:52 ` Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH 14/19] arm64: dts: qcom: x1e80100: Fix CDSP memory length Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH PATCH RFT 15/19] arm64: dts: qcom: sm6350: Fix ADSP " Krzysztof Kozlowski
2024-12-06 15:55 ` Luca Weiss [this message]
2024-12-06 15:32 ` [PATCH PATCH RFT 16/19] arm64: dts: qcom: sm6350: Fix MPSS " Krzysztof Kozlowski
2024-12-06 15:56 ` Luca Weiss
2024-12-06 15:32 ` [PATCH PATCH RFT 17/19] arm64: dts: qcom: sm6375: Fix ADSP " Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH PATCH RFT 18/19] arm64: dts: qcom: sm6375: Fix CDSP memory base and length Krzysztof Kozlowski
2024-12-06 15:32 ` [PATCH PATCH RFT 19/19] arm64: dts: qcom: sm6375: Fix MPSS " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D64QNNAMVMJM.3NDC6J100E8ME@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox