From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 2/2] iio: veml3235: fix scale to conform to ABI
Date: Tue, 31 Dec 2024 09:39:03 +0100 [thread overview]
Message-ID: <D6PR0XZ27Z67.1IJEM2DOL18QY@gmail.com> (raw)
In-Reply-To: <20241230-veml3235_scale-v3-2-48a5795e2f64@gmail.com>
On Mon Dec 30, 2024 at 4:13 PM CET, Javier Carrasco wrote:
> The current scale is not ABI-compliant as it is just the sensor gain
> instead of the value that acts as a multiplier to be applied to the raw
> value (there is no offset).
>
> Use the iio-gts helpers to obtain the proper scale values according to
> the gain and integration time to match the resolution tables from the
> datasheet. When at it, use 'scale' instead of 'gain' consistently for
> the get/set functions to avoid misunderstandings.
>
> Fixes: c5a23f80c164 ("iio: light: add support for veml3235")
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> drivers/iio/light/Kconfig | 1 +
> drivers/iio/light/veml3235.c | 237 +++++++++++++++++++++++--------------------
> 2 files changed, 130 insertions(+), 108 deletions(-)
>
@Jonathan, if you apply this patch in its current form, could you please
fix the message from "iio: veml3235:..." to "iio: light: veml3235:..."?
I just noticed that the "light:" bit is missing.
I can send a new version if that's preferred.
The applied patches from this series did not have this issue.
Thanks and best regards,
Javier Carrasco
next prev parent reply other threads:[~2024-12-31 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 15:13 [PATCH v3 0/2] iio: light: fix scale in veml3235 and add helpers to iio-gts Javier Carrasco
2024-12-30 15:13 ` [PATCH v3 1/2] iio: gts-helper: add helpers to ease searches of gain_sel and new_gain Javier Carrasco
2024-12-30 15:13 ` [PATCH v3 2/2] iio: veml3235: fix scale to conform to ABI Javier Carrasco
2024-12-31 8:39 ` Javier Carrasco [this message]
2025-01-04 12:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6PR0XZ27Z67.1IJEM2DOL18QY@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox