From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7331EF094 for ; Mon, 20 Jan 2025 19:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737402255; cv=none; b=LE7oTGViHS2oNLdO+5n2G0SHkhfOJ4lK9Ci7pzjBiu28DzrT52A+yPS8J1ZVIceUD4TPIzjSSJClxnp0yBrXSIM4mCGuPYSczvi3T1l01vZAtLAmITvbrqDQsUUxBXJpjzlDYYi34UXlSw2z+MUJVKTYfuTEy/TNlbvW4WPjJzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737402255; c=relaxed/simple; bh=z7P+J0mI/+oPm1CcA8nyV1W2/nZnyL2Ug4ktxwTF8kw=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=aDDPi9DbR6lD3h8EpfdxfUe/IPnikGtVLEmO/0z1vd22oFB8FTd7Vxc3Nf523iY/yryvUthrm4jaFCArXRBlJgdywD0P54U7BjPA7qW7it8ELSKMN+7WElemgkIvMTe3zKjIgHW+DHEaqfaetjdvSnaKHeA68CYn14DSHeGC62Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=Nv2DeSGi; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="Nv2DeSGi" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1737402240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5RLve09pHXyDwibCb60WvsnrRpSp359iWUXBWVIy1PI=; b=Nv2DeSGiFIx4Z309t7HF/4zhQcgnLOsu0UfBrFN7wJt/JIoTB4p/3oDnyt5TeQzECeyuel bgJUCWLa6ljUwXaw1Lf3O7znvOcsPTZ3uRU0XWOx5ez/NyxD+0UPENKbR3xszzfc6nWdhx fLAktCxX4d2wzE/ZaHdTxrgiVn4lRKOWDb5EwEzsB/4xf+6hgDXsOjrALmYwehSciTdGln t5jfzOUqfNeuoQpRLx0YLsu4GtE5faDd2zRIZNmQCCvl3HA8YxteRXLChw4AH7TAWJhPhO K9Kv2TAa72/ISOjYMcRFSW+J6xJQ411uzxLnXXt7zbA2GrSXGLXh3WYPJn3eyA== Content-Type: multipart/signed; boundary=ca11871e295c846aed4751d9c823cec546d395094f287aeab8421f6af7ef; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Mon, 20 Jan 2025 20:43:49 +0100 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Benjamin Gaignard" , , , Cc: , , Subject: Re: [PATCH v3] media: verisilicon: HEVC: Initialize start_bit field References: <20250120153555.404806-1-benjamin.gaignard@collabora.com> In-Reply-To: <20250120153555.404806-1-benjamin.gaignard@collabora.com> X-Migadu-Flow: FLOW_OUT --ca11871e295c846aed4751d9c823cec546d395094f287aeab8421f6af7ef Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Jan 20, 2025 at 4:35 PM CET, Benjamin Gaignard wrote: > Always set start_bit field to 0, if not it could lead to corrupted frames > specially when decoding VP9 bitstreams at the same time since VP9 driver > set it for its own purpose. > > Fixes: cb5dd5a0fa51 ("media: hantro: Introduce G2/HEVC decoder") > Signed-off-by: Benjamin Gaignard > Tested-by: Nicolas Dufresne In the mail that contained the Tested-by tag there was also a Reviewed-by tag (from Nicolas) further down below. (sorry about the other mail; sth went wrong) > --- > drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c b/dr= ivers/media/platform/verisilicon/hantro_g2_hevc_dec.c > index 85a44143b378..0e212198dd65 100644 > --- a/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c > +++ b/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c > @@ -518,6 +518,7 @@ static void set_buffers(struct hantro_ctx *ctx) > hantro_reg_write(vpu, &g2_stream_len, src_len); > hantro_reg_write(vpu, &g2_strm_buffer_len, src_buf_len); > hantro_reg_write(vpu, &g2_strm_start_offset, 0); > + hantro_reg_write(vpu, &g2_start_bit, 0); > hantro_reg_write(vpu, &g2_write_mvs_e, 1); > =20 > hantro_write_addr(vpu, G2_TILE_SIZES_ADDR, ctx->hevc_dec.tile_sizes.dma= ); --ca11871e295c846aed4751d9c823cec546d395094f287aeab8421f6af7ef Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZ46neAAKCRDXblvOeH7b bpKnAQC5dzfDBEJ+T/sVxmb4LBfT8d37/MjDvpBq72uvBqaJ5gEAtnbofxNYAnzJ Dej14FaOWZ/N+ZrZgFmVhoR6q/3G+wo= =RCze -----END PGP SIGNATURE----- --ca11871e295c846aed4751d9c823cec546d395094f287aeab8421f6af7ef--