Re: [PATCH 3/3] x86/sev: add a SVSM vTPM platform device

Jason Gunthorpe
2024-12-10T14:40:27Z

On Tue, Dec 10, 2024 at 03:34:23PM +0100, Stefano Garzarella wrote:

> + if (platform_device_add_data(&tpm_device, &pops, sizeof(pops)))
> + return -ENODEV;
> + if (platform_device_register(&tpm_device))
> + return -ENODEV;

This seems like an old fashioned way to instantiate a device. Why do
this? Just put the TPM driver here and forget about pops? Simple tpm
drivers are not very complex.

Jason