Re: [PATCH v2 3/4] iio: gts-helper: export iio_gts_get_total_gain()

Matti Vaittinen
2025-01-24T08:12:46Z

On 19/01/2025 19:32, Javier Carrasco wrote:
> Export this function in preparation for the fix in veml6030.c, where the
> total gain can be used to ease the calculation of the processed value of
> the IIO_LIGHT channel compared to acquiring the scale in NANO.
>
> Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Hi Javier,

This is fine but could you please go the extra mile and add a doc to the
function? I'd like to have kerneldoc for all exported functions.

> ---
> drivers/iio/industrialio-gts-helper.c | 3 ++-
> include/linux/iio/iio-gts-helper.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c
> index d70ebe3bf7742906960c6af22102682c5b8dcdfa..6ec434338411d09fffa1db52046a7df9b34c89bf 100644
> --- a/drivers/iio/industrialio-gts-helper.c
> +++ b/drivers/iio/industrialio-gts-helper.c
> @@ -950,7 +950,7 @@ int iio_gts_find_gain_time_sel_for_scale(struct iio_gts *gts, int scale_int,
> }
> EXPORT_SYMBOL_NS_GPL(iio_gts_find_gain_time_sel_for_scale, "IIO_GTS_HELPER");
>
> -static int iio_gts_get_total_gain(struct iio_gts *gts, int gain, int time)
> +int iio_gts_get_total_gain(struct iio_gts *gts, int gain, int time)
> {
> const struct iio_itime_sel_mul *itime;
>
> @@ -966,6 +966,7 @@ static int iio_gts_get_total_gain(struct iio_gts *gts, int gain, int time)
>
> return gain * itime->mul;
> }
> +EXPORT_SYMBOL_NS_GPL(iio_gts_get_total_gain, "IIO_GTS_HELPER");
>
> static int iio_gts_get_scale_linear(struct iio_gts *gts, int gain, int time,
> u64 *scale)
> diff --git a/include/linux/iio/iio-gts-helper.h b/include/linux/iio/iio-gts-helper.h
> index e5de7a124bad6eb65414df364f84e81301b0690b..66f830ab9b49b566d549c7b5b8291d42a0825b96 100644
> --- a/include/linux/iio/iio-gts-helper.h
> +++ b/include/linux/iio/iio-gts-helper.h
> @@ -208,5 +208,6 @@ int iio_gts_all_avail_scales(struct iio_gts *gts, const int **vals, int *type,
> int *length);
> int iio_gts_avail_scales_for_time(struct iio_gts *gts, int time,
> const int **vals, int *type, int *length);
> +int iio_gts_get_total_gain(struct iio_gts *gts, int gain, int time);
>
> #endif
>