Re: [PATCH v2 4/4] iio: light: veml6030: fix scale to conform to ABI

Matti Vaittinen
2025-01-24T08:24:56Z

On 19/01/2025 19:32, Javier Carrasco wrote:
> The current scale is not ABI-compliant as it is just the sensor gain
> instead of the value that acts as a multiplier to be applied to the raw
> value (there is no offset).
>
> Use the iio-gts helpers to obtain the proper scale values according to
> the gain and integration time to match the resolution tables from the
> datasheet and drop dedicated variables to store the current values of
> the integration time, gain and resolution. When at it, use 'scale'
> instead of 'gain' consistently for the get/set functions to avoid
> misunderstandings.
>
> Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Hi Javier,

Sorry for the delay - been a bit busy lately. I didn't do a thorough
review but the total_gain (and rest of the GTS) usage looked good to me :)

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>