Re: [PATCH v9 11/14] platform/x86: Split the alienware-wmi driver

["Kurt Borja" <kuurtb@gmail.com>]

On Fri Feb 7, 2025 at 10:05 AM -05, Ilpo Järvinen wrote:
> On Fri, 7 Feb 2025, Kurt Borja wrote:
>
>> Split alienware-wmi WMI drivers into different files. This is done
>> seamlessly by copying and pasting, however some blocks are reordered.
>> 
>> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
>> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>
> Hi,
>
> Can you please check there's no error in driver_data assignments as the 
> numbers in removed & added lines do not match:

Hi Ilpo,

There was indeed a wrong assignment to Alienware m16 r1 AMD, I'm not
really sure how it happened but it's fixed now!

I'll send a v10. I apologize for the noise.

>
> $ git diff-tree -p 73224c076cf2fa2968d61584c62937f6180c8e71 | grep driver_data | rev | sort | rev | uniq -c

Thanks for this amazing trick btw.

~ Kurt

>       1 +               awcc = id->driver_data;
>       1 -               awcc = id->driver_data;
>       4 +               .driver_data = &generic_quirks,
>       5 -               .driver_data = &generic_quirks,
>       7 +               .driver_data = &g_series_quirks,
>       6 -               .driver_data = &g_series_quirks,
>
> (That commit id is from my staging tree, not available to you but it's 
> this patch.)