From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Ahmed Salem" <x0rw3ll@gmail.com>, <peterhuewe@gmx.de>,
<jgg@ziepe.ca>, <shuah@kernel.org>, <skhan@linuxfoundation.org>
Cc: <linux-integrity@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests: tpm2: test_smoke: use POSIX-conformant expression operator
Date: Mon, 10 Feb 2025 19:35:28 +0200 [thread overview]
Message-ID: <D7OY3ZVGJOV5.R3SL9SBFT2DF@kernel.org> (raw)
In-Reply-To: <zdfnlpdb24tk6aikzucyomylf4lqdyhdvlingwyku46fy75eyg@giq5dqojdxj5>
On Mon Feb 10, 2025 at 7:03 PM EET, Ahmed Salem wrote:
> test_smoke.sh:9: expression uses non POSIX-conformant operator
> symbol '==', resulting in skipping the remaining tests.
>
> This patch ensures the use of POSIX-conformant operator symbol '='.
>
> w/o this patch for test_smoke.sh
> ================================
> $ sudo make -j8 TARGETS=tpm2 kselftest
> make[3]: Nothing to be done for 'all'.
> TAP version 13
> 1..3
> # timeout set to 600
> # selftests: tpm2: test_smoke.sh
> # ./test_smoke.sh: 9: [: 2: unexpected operator
> ok 1 selftests: tpm2: test_smoke.sh # SKIP
The fix is fine but cut out snippets of transcripts pinpointing
the issue.
BR, Jarkko
next prev parent reply other threads:[~2025-02-10 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 17:03 [PATCH] selftests: tpm2: test_smoke: use POSIX-conformant expression operator Ahmed Salem
2025-02-10 17:35 ` Jarkko Sakkinen [this message]
2025-02-11 0:56 ` [PATCH v2] " Ahmed Salem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7OY3ZVGJOV5.R3SL9SBFT2DF@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=x0rw3ll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox