Re: [PATCH 1/4] media: dt-bindings: Add Sony IMX728

Krzysztof Kozlowski
2025-02-12T20:08:03Z

On 12/02/2025 20:56, Sebastian LaVine wrote:
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + Specifier for the GPIO connected to the XCLR (System Reset) pin.

s/Specifier for the GPIO connected to the//
But you could say that it is active low, for example.

> +
> + error0-gpios:
> + maxItems: 1
> + description:
> + Specifier for the GPIO connected to the XWRN pin.

The same.

> +
> + error1-gpios:
> + maxItems: 1
> + description:
> + Specifier for the GPIO connected to the XERR pin.
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: ../video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + clock-frequency = <400000>;

Drop, not really relevant.

> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@1a {
> + compatible = "sony,imx728";
> + reg = <0x1a>;
> +
> + clocks = <&fixed_clock>;
> + clock-names = "inck";
> +
> + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> + error0-gpios = <&sens_exp 1 GPIO_ACTIVE_HIGH>;
> + error1-gpios = <&sens_exp 2 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + camera1: endpoint {
> + remote-endpoint = <&vin1a_ep>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 575f0e6f0532..50bff3558d7d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21885,6 +21885,12 @@ T: git git://linuxtv.org/media.git
> F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> F: drivers/media/i2c/imx415.c
>
> +SONY IMX728 SENSOR DRIVER
> +M: Stuart Burtner <sburtner@d3embedded.com>
> +L: linux-media@vger.kernel.org
> +S: Odd Fixes

Hm, why only odd fixes? If you don't care about driver, we also kind of
might not care and remove it soon.

> +F: Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
> +
> SONY MEMORYSTICK SUBSYSTEM
> M: Maxim Levitsky <maximlevitsky@gmail.com>
> M: Alex Dubov <oakad@yahoo.com>
> --
> 2.34.1
>
> Please be aware that this email includes email addresses outside of the organization.

Obviously. Please drop it. You can use b4 relay if you need to escape
corporate junk.

Best regards,
Krzysztof