From: Benno Lossin <benno.lossin@proton.me>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Tamir Duberstein" <tamird@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Andrew Ballance" <andrewjballance@gmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rust: alloc: replace `Vec::set_len` with `inc_len`
Date: Mon, 17 Mar 2025 14:43:39 +0000 [thread overview]
Message-ID: <D8IMDF0SXKHY.2Q57PAP87OBQV@proton.me> (raw)
In-Reply-To: <CANiq72nZrHzhYztDMQnhuW3hhg3eXtwM+kZMd=3ARbWZTZWe9g@mail.gmail.com>
On Mon Mar 17, 2025 at 11:23 AM CET, Miguel Ojeda wrote:
> On Mon, Mar 17, 2025 at 10:58 AM Benno Lossin <benno.lossin@proton.me> wrote:
>>
>> What if this overflows? Do we always have overflow debugging on when
>> debug assertions are enabled? If yes, then this is fine.
>
> No, they are independent settings.
I see, then this needs to be `checked_add` or some avoid the overflow
some different way.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-03-17 14:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 22:31 [PATCH 0/2] rust: alloc: split `Vec::set_len` into `Vec::{inc,dec}_len` Tamir Duberstein
2025-03-16 22:32 ` [PATCH 1/2] rust: alloc: replace `Vec::set_len` with `inc_len` Tamir Duberstein
2025-03-17 9:58 ` Benno Lossin
2025-03-17 10:23 ` Miguel Ojeda
2025-03-17 14:43 ` Benno Lossin [this message]
2025-03-17 10:48 ` Alice Ryhl
2025-03-17 11:25 ` Tamir Duberstein
2025-03-17 14:46 ` Benno Lossin
2025-03-17 15:01 ` Tamir Duberstein
2025-03-17 10:50 ` Alice Ryhl
2025-03-17 11:16 ` Danilo Krummrich
2025-03-17 11:25 ` Tamir Duberstein
2025-03-16 22:32 ` [PATCH 2/2] rust: alloc: add `Vec::dec_len` Tamir Duberstein
2025-03-16 22:35 ` Tamir Duberstein
2025-03-16 22:41 ` Danilo Krummrich
2025-03-16 22:47 ` Tamir Duberstein
2025-03-16 23:02 ` Danilo Krummrich
2025-03-16 23:27 ` Tamir Duberstein
2025-03-17 11:22 ` Danilo Krummrich
2025-03-17 11:34 ` Tamir Duberstein
2025-03-17 10:04 ` Benno Lossin
2025-03-17 11:34 ` Tamir Duberstein
2025-03-17 11:47 ` Alice Ryhl
2025-03-17 12:59 ` Alice Ryhl
2025-03-17 13:53 ` Tamir Duberstein
2025-03-18 9:30 ` Alice Ryhl
2025-03-18 14:12 ` Tamir Duberstein
2025-03-18 14:44 ` Alice Ryhl
2025-03-18 18:28 ` Tamir Duberstein
2025-03-18 18:46 ` Danilo Krummrich
2025-03-18 18:53 ` Tamir Duberstein
2025-03-18 19:26 ` Danilo Krummrich
2025-03-18 20:05 ` Tamir Duberstein
2025-03-18 20:13 ` Tamir Duberstein
2025-03-18 20:15 ` Danilo Krummrich
2025-03-17 14:42 ` Benno Lossin
2025-03-17 14:44 ` Tamir Duberstein
2025-03-17 16:16 ` Danilo Krummrich
2025-03-17 16:21 ` Tamir Duberstein
2025-03-17 14:39 ` Benno Lossin
2025-03-17 15:37 ` Tamir Duberstein
2025-03-17 15:57 ` Miguel Ojeda
2025-03-17 17:24 ` Benno Lossin
2025-03-17 17:28 ` Tamir Duberstein
2025-03-19 21:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8IMDF0SXKHY.2Q57PAP87OBQV@proton.me \
--to=benno.lossin@proton.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox