Re: [PATCH 13/16] i2c: busses: at91: Add MCHP_LAN966X_PCI dependency

Herve Codina
2025-04-08T14:05:51Z

Hi Andy,

On Mon, 7 Apr 2025 18:42:55 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Apr 07, 2025 at 04:55:42PM +0200, Herve Codina wrote:
> > The AT91 I2C driver depends on ARCH_AT91.
> >
> > This I2C controller can be used by the LAN966x PCI device and so
> > it needs to be available when the LAN966x PCI device is enabled.
>
> ...
>
> > config I2C_AT91
> > tristate "Atmel AT91 I2C Two-Wire interface (TWI)"
> > - depends on ARCH_AT91 || COMPILE_TEST
> > + depends on ARCH_AT91 || MCHP_LAN966X_PCI || COMPILE_TEST
>
> I would drop it altogether in similar way as suggested for the clock driver.
>

IMHO, they should be kept for the reason mentionned for the clock driver.

Best regards,
Hervé