Re: [PATCH 3/3] platform/x86: dell-pc: Transition to faux device

["Kurt Borja" <kuurtb@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 3551 bytes --]

On Thu Apr 24, 2025 at 8:57 AM -03, Ilpo Järvinen wrote:
> On Wed, 23 Apr 2025, Hans de Goede wrote:
>> On 23-Apr-25 6:14 PM, Kurt Borja wrote:
>> > On Wed Apr 23, 2025 at 10:44 AM -03, Hans de Goede wrote:
>> >> On 23-Apr-25 3:27 PM, Ilpo Järvinen wrote:
>> >>> On Fri, 11 Apr 2025, Kurt Borja wrote:
>> >>>
>> >>>> Use a faux device parent for registering the platform_profile instead of
>> >>>> a "fake" platform device.
>> >>>>
>> >>>> The faux bus is a minimalistic, single driver bus designed for this
>> >>>> purpose.
>> >>>
>> >>> Hi Kurt, Hans & Greg,
>> >>>
>> >>> I'm not sure about this change. So dell-pc not a platform device but
>> >>> a "fake".
>> >>
>> >> Arguably the dell-pc driver does not need a struct device at all,
>> >> since it just exports /sys/firmware/acpi/platform_profile sysfs
>> >> interface by using the relevant Dell SMBIOS interfaces for this.
>> >>
>> >> As such maybe we should just completely get rid of the whole
>> >> struct device here?
>> >>
>> >> If we do decide to keep the struct device, then since the struct device
>> >> seems to just be there to tie the lifetime of the platform_profile
>> >> handler to, I guess that calling it a faux device is fair.
>> > 
>> > I think it's important to mention that a parent device is required to
>> > register a platform profile, see [1].
>> 
>> Ah ok, that is new, I guess that was changed with the new support
>> for registering multiple platform-profile handlers.
>> 
>> > I guess we could get away with removing the device altogether from here,
>> > but that would require to find another suitable parent device. The
>> > obvious choice would be the `dell-smbios` device, however that would
>> > require exporting it in the first place.
>> > 
>> > For some reason, exporting devices doesn't seem right to me, so IMO a
>> > faux device is a good choice here.
>> 
>> Agreed.
>> 
>> > Another solution that would make more sense, lifetime wise, is to turn
>> > this into an aux driver and let `dell-smbios` create the matching aux
>> > device.
>
> Well, that was what caused part of my confusion / uncertainty here as
> I could see that aux bus between these two drivers. Obviously, it's not 
> there currently but conceptually this relationship looks what full-blown 
> aux bus was supposed to solve.
>
> The other part was that as per Greg's simple classification, certainly 
> this driver needs to access platform resources. BUT, that access is routed 
> through another driver which is a case his answer/classification did not 
> cover.

Perhaps it didn't cover it because, as you mentioned, this falls under
the aux bus use cases.

>
>> > I could do this, but I think it's overly complicated.
>>
>> Yes that does seem overly complicated, lets just go with the faux
>> device.
>
> Okay. In part, this was also to check whether replacing full-blown aux bus 
> with faux should be considered another kind of "abuse". I've no problem 
> with accepting faux for cases like this as I see these as policy / 
> convention decision more than one being right and another wrong. :-)

Now that you put it that way, I guess this still is kind of "abusive",
but is still an improvement over creating a full platform device.

Nevertheless, although this driver do access platform resources, it does
it completely detached from the "dell-smbios" device. The only use of
the platform device here was `&pdev->dev` :p

>
> Thanks to all who answered.

Thanks for your review!

-- 
 ~ Kurt

[-- Attachment #1.2: 57E3B6585920A69A.asc --]
[-- Type: application/pgp-keys, Size: 4349 bytes --]

-----BEGIN PGP PUBLIC KEY BLOCK-----

mQINBGgKemsBEADlBa3abjsoEof7YAphRayi3YrBgIp06UinSkhCkv7g4daNUUvz
D8clrNHZ6GCt4DXEjbbApQZaZSwn+/e0Gt7FAK8HYftVir158tftWk8JPqN3cZaH
a15B+0svYc9bBsmSZyMNsllIBOE3h4oSqIVrPuEWEqK+6cCaccj95zwYjsJ/T4XR
AlReC13r1tQ4zOOii9LgULfqXHmUkrxxvzLLB7ZAgsxEIT1nN+zJvPxCeNGjqY1B
ID0l5AWyrtp3bQFrcZN/RDlpDwS0kopvZaYxCL7ZxOoZtwv9Tz6gP30Wrcx5JGQq
zvRpmU++TYkNBTi/gXwUTbibTT9ARF5/IERnOrDe73Ylz770yP4fS4Vp9epMphjN
J59Fdk0TaksL6tAckZ3RVcLkjBIj7asXf9tqM6GP4uX4lZvc9AWtCbFEFjwYATru
h1fczHbq7x+Escgc3baob5WpAvDRV2U6aFeYJw8T2SqHEr9O7MPHV9GdvOKarks1
PzjxP+29vX0+ySR7kPcl3duuJcxPutBK/4tyYgimEABYuKvZgfKZVBtEDPXy3Sx/
meWxCb4aihSCFvoeMZQJijNrMa/VHJPjzxKzjDDtCLmZsSeDjXGjOEzEalO4HtHp
nSymg8urfrrRtHZK5yQ++h2a8XctnPkrU7r0L1BoA5E54uqPGjgoYo4n9QARAQAB
tB1LdXJ0IEJvcmphIDxrdXVydGJAZ21haWwuY29tPokCVwQTAQgAQQIbAQULCQgH
AgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBFTTvhcK73d5g8PGO1fjtlhZIKaaBQJo
CnxxBQkE6GeGAAoJEFfjtlhZIKaa/GUP/R3wfzFRK+SnTo5tbJARBG9eEzLcIcLk
+aC840gz13oLWD0HWs90DjqNOz4PfPYWyEljedg33ecgQi5A0T4uE3PLoczB1cGm
UKbNwEU3URnzxRGm8e2S1CyayUQBFlNaJlScokLYoJbxpeFNCbUTMXuayono6vlz
mOGFflie99u6RsfaTG+QoC2uRPvWcpapUPFPswbOcoYKs+joDlevAChLv/DzqVTn
coLgTQTUI5tDkFPP1D8QToxfR4jBCvBslFrP+veKZEyUrvHKggNQEHBXzfCNYWfz
m5O4zYQbTK45ITyEfcFweJHjXDfw1PVppfzgT5Bx0OpCNylj7NE5whTpRnKTipn+
/WnNryDCnRfTvAQ/ssAp0UsC4eGfGgH9HO+jmTB2rKFsSjtZCm/wiTTJ+q8gWRzG
y8WXBau1NntAQ9zI5SZs+sbJmSMqrt7SB/NGb67vNt3jenWc2XiIeZ4XYzSLqpTP
8UIa959jDj+DJBRYBJAPHCan1/0qE0dx9cDgDxOUqQM0dzjw4e/PX2Px4UdW/Sn7
hDbDpAF1xi+t51K4fc1ewATLlnURddmIToZfbfqSnB12AI9ljoYNNzhNPcYbviQV
HS7cU8Vyuxao1oy3njxDWMrkRF8p105o6yveAqILqrj+0hQKycchw3qqdvxQ+wVJ
JaKk4wpR1Jm6uDgEaAp7kBIKKwYBBAGXVQEFAQEHQOwklpBpjcr2GFlZhbGaWZLs
b04yNqi+0PQGgJQ1xH1rAwEIB4kCNgQYAQgAIBYhBFTTvhcK73d5g8PGO1fjtlhZ
IKaaBQJoCnuQAhsMAAoJEFfjtlhZIKaaXHQP/2M2yaOLUvm9ycz909kgSLow/9Qh
ztffxyO2GDDeXzUB9g1iCY5ssdgSiR5ygxrzwqjZwuAGk2voE6D9zRvwlCjUe/Yc
/IU6bSwwLEoa5O772EnbIzJvVEaLY3bYtviNNJixkAkRB0KX8V/fkgy2MEKTl1cO
rtoj3UKX1XTdgeh26X/2qS93iAKsUur2268U5EQsSf2A8UB38XYu48FGGQkW6aAS
4pONJV50WsiFGfZpiQbSa7XCj5pz5ba+vGSC/OHymCMAb+gRP3jdD0h35HXEkzQC
RTYzxWdfnWcBHgCl4SQN3pAnZp898/ay4+3rAg/T7eAcW3RTgU/HUEG24GzqNHJf
Lb5xtD9DBpjkhujlIo1Ggzl5APItcCRxDM3P0lCw8V+gkK5cKSfL/kh73qmb4KXq
4Em9I2m2xg2E6dQw7p4cksWUDbkoKbGMI52S/q6PQLN4i5IM2FBBIpZzFJFm7Hlq
40vHGwQyc61M4kNRhMX5e6ctdVE6Q7PbF64MQ3oY+sSTMc2sg6g1/cYdKseTzAK3
A14sw61CbDcnarU/v/fXDn5GsnhMByxHyGcTpxKar+OZxapHI0hJsJPIj01Ylqq7
PEu4Nqhmtmz5ubHF+aSR+PxaRi2uUUgzZnZfqmZle4GnQ0D8vyE7zM8mI78I/NGw
BLElwcXPsQBf3G5auDMEaAp7txYJKwYBBAHaRw8BAQdAy7v1AAo9uvDYGAxCfnrw
nXKW3QHPfQp9reFXSlDxtDOJAq0EGAEIACAWIQRU074XCu93eYPDxjtX47ZYWSCm
mgUCaAp7twIbAgCBCRBX47ZYWSCmmnYgBBkWCgAdFiEEh2Ci9uJabu1OwFXfFmBD
OPSf1GYFAmgKe7cACgkQFmBDOPSf1GaznAEAzDC4NSbsiPck4j4K+vBh4VjUW3Jd
M05VC5KqoEs4KbgBAI4XrcqkDhjDoVnudL2CMRClkLBZdCIacm5kVeKZQgUM45EQ
AKQbwP3P7kZt52oo5xZV1yrap7VfvBnjpIwNsjT/4p1W5Wwzriet5ximkm6tf/ub
FWlE22WWjtBmed9fGR5NZoGowPAjt/rFN2zOsFQWdOApeUlzzmVMLNZjp030h3Xg
oNPRP3W7Cb1FocGIgJgcJ5UsKKoTTCa0jebjnMshen+nlr4JI6dINeCRYw1nh+9b
yr1UoatS35vHJLBaUkLuBv8XUPRmKK7rkhhvyVv/NKfIcia+Mr6h5BVOls7T3mD0
7OFbpqbdOHva/xvL/66DUp5riJ3CzvOLaQXMiCHsxvymwJ6Iajxvl26YmZ7Tyavt
v+koowloExuVoGRtdMv+oP1mnTeidIx1Qn+i0a9H3QWSfnbPD8pEoDoDVrFubxdM
FIwEZ4kc9rUXXvu8sVhCM9N/YSam7zEAOUhQJNUGbNpK8HgL32kaTKJxkUQB571P
F8CgGPE6RNoEnA/9IQIKCEL2x03N0evnGktiXgpFsKzsZUrMHlyRplh3kkPHytAG
PcY6KR5P4rh2TYaO+ZAklCyLF0mbno8BSVq/liuzfC4yCkh/tYh8uXG+ezNllaBz
g3RSp7b0MeiiDNGOdHlgouhcpRIS4R/RFarkO4Z26TX+NVIv1H8pLji3/gcaXWDb
NSsfJULbL+IE/Yfr8Nj8Rt5YJZwhHmxMIVwuhCi9JH+IuDMEaAp7xxYJKwYBBAHa
Rw8BAQdAKkxKhQUR39+VwLvyev1AR1l1ardbn+qtj2PicyY0CRGJAjYEGAEIACAW
IQRU074XCu93eYPDxjtX47ZYWSCmmgUCaAp7xwIbIAAKCRBX47ZYWSCmmgllD/4h
f+MD3lHN/z4kI8zjKJ4sh+6wq79Mb1lGZyFgNm4ZW8TYJVN6G/CJN/Y/AFwX0izj
Qamzs6A5FZf6EFR4lkbFLFFU8QtC3NeddlC8Rq9C409wrbR+G/Qp78KWyvyVMeEI
U0Qk4mtmGmrnkKpii116O5uof3W2eVzYry9AlWNk0qP2DZ/BxYL8XBH+mkLPyLKa
O60fXflRL+616kd5IAffwZq97mWU9GSkmeY984D+cqXrqWCXx1UlHz+qzszzAkzH
muz2NRWloicZ0MrcHw5ftDvIzY1hIRdRcHdk3tLDpXxkZldDDS43apGLGeDf3rHz
QHgDtCSx1fT3OL2PT8nZPki3mnWJ/KwX6u2rrErP92OYPX1ACcwQ3uKNlvevZkXU
amaRoIrZD65EDobgokCwwfoK0Ga+8I0oftFKBV5CZFixl9hf8XzjWK6eif8QUk38
fhheO3PpIAxh8+pHzpdIjEAJI3ycbdYhFRXprN610K37cXmwljrD/YhiyUHLAIHf
9RepyH30UJLiwVNMHOZlRnp4GaKEkpGP0tSE2ZoSGWuCw7BzOQmjTnRrow41SmWN
CG13hiGSG3hvTwkgOYr7fJQydFqQd+NOnp3aDc8r+2josRWp9MiwlK2euRkTygsy
wOBUvzk73mjU+O6iYOw7hhDbXKcZ3HQ/5mh5b8FCzA==
=GRvV
-----END PGP PUBLIC KEY BLOCK-----

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]