public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Andrew Morton <akpm@zip.com.au>
Cc: dalecki@evision-ventures.com, viro@math.psu.edu,
	linux-kernel@vger.kernel.org
Subject: Re: IDE hang, partition strangeness
Date: Fri, 2 Aug 2002 12:15:10 +0200	[thread overview]
Message-ID: <DA7022651A@vcnet.vc.cvut.cz> (raw)

On  1 Aug 02 at 23:56, Andrew Morton wrote:
> > 
> > Seems that the partitioning code in 2.5.30 is sending illegal LBAs
> > to the IDE driver, which responds by hanging the box:
> 
> I misread this backtrace:
> 
> _this_ is the lba. 160086527.  It is the very last sector on the disk.

Did not it issued an error on the console before that? Something
like 'hda: xxxx: status=YY' ? If it did, just open
drivers/ide/ide.c in your favorite editor, locate function ata_error,
in this function locate 'if (rq->errors >= ERROR_MAX)' and replace
it with 'if (1)'... 

Problem is that current IDE code does not start retry, although it 
thinks that it started it - so code waits for something to happen,
without timer set up, and without xxx->handler set to anything, so
even if something will happen (spurious interrupt), it will not awake.

Changing condition to '1' will force IDE driver to fail operation 
immediately, and so channel will not deadlock (put it in another 
way: any time current ata_error returns ATA_OP_CONTINUES, you just 
lost your IDE channel with kernels >= 2.5.27 (at least)).
                                            Petr Vandrovec
                                            vandrove@vc.cvut.cz
                                            

             reply	other threads:[~2002-08-02 10:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-02 10:15 Petr Vandrovec [this message]
2002-08-02 17:58 ` IDE hang, partition strangeness Andrew Morton
2002-08-03 23:35   ` Marcin Dalecki
  -- strict thread matches above, loose matches on Subject: below --
2002-08-02  6:02 Andrew Morton
2002-08-02  6:56 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA7022651A@vcnet.vc.cvut.cz \
    --to=vandrove@vc.cvut.cz \
    --cc=akpm@zip.com.au \
    --cc=dalecki@evision-ventures.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox