From: "Benno Lossin" <lossin@kernel.org>
To: "Danilo Krummrich" <dakr@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>,
<david.m.ertman@intel.com>, <ira.weiny@intel.com>,
<leon@kernel.org>, <kwilczynski@kernel.org>,
<bhelgaas@google.com>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] rust: devres: implement register_release()
Date: Mon, 23 Jun 2025 00:29:52 +0200 [thread overview]
Message-ID: <DATF1BEX3XN4.LCZYZASKZA9P@kernel.org> (raw)
In-Reply-To: <aFh0p5p_89025kcg@pollux>
On Sun Jun 22, 2025 at 11:24 PM CEST, Danilo Krummrich wrote:
> On Sun, Jun 22, 2025 at 11:12:28PM +0200, Danilo Krummrich wrote:
>> On Sun, Jun 22, 2025 at 10:47:55PM +0200, Benno Lossin wrote:
>> > And maybe a closure design is better, depending on how much code is
>> > usually run in `release`, if it's a lot, then we should use the trait
>> > design. If it's only 1-5 lines, then a closure would also be fine. I
>> > don't have a strong preference, but if it's mostly one liners, then
>> > closures would be better.
>>
>> It should usually be rather short, so probably makes sense.
>
> Quickly tried how it turns out with a closure: The only way I know to capture
> the closure within the
>
> unsafe extern "C" fn callback<P>(ptr: *mut kernel::ffi::c_void)
>
> is with another dynamic allocation, which isn't worth it.
>
> Unless there's another way I'm not aware of, I'd keep the Release trait.
Ah right that makes sens.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-06-22 22:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 16:40 [PATCH v2 0/4] Improvements for Devres Danilo Krummrich
2025-06-22 16:40 ` [PATCH v2 1/4] rust: revocable: support fallible PinInit types Danilo Krummrich
2025-06-22 20:23 ` Benno Lossin
2025-06-22 20:30 ` Miguel Ojeda
2025-06-23 11:53 ` Alice Ryhl
2025-06-22 16:40 ` [PATCH v2 2/4] rust: devres: replace Devres::new_foreign_owned() Danilo Krummrich
2025-06-22 20:25 ` Benno Lossin
2025-06-23 11:56 ` Alice Ryhl
2025-06-23 12:41 ` Danilo Krummrich
2025-06-22 16:40 ` [PATCH v2 3/4] rust: devres: get rid of Devres' inner Arc Danilo Krummrich
2025-06-22 20:45 ` Benno Lossin
2025-06-22 21:09 ` Danilo Krummrich
2025-06-23 1:54 ` Boqun Feng
2025-06-24 15:18 ` Danilo Krummrich
2025-06-24 15:46 ` Boqun Feng
2025-06-24 16:15 ` Danilo Krummrich
2025-06-24 16:20 ` Danilo Krummrich
2025-06-24 16:37 ` Boqun Feng
2025-06-22 16:40 ` [PATCH v2 4/4] rust: devres: implement register_release() Danilo Krummrich
2025-06-22 20:47 ` Benno Lossin
2025-06-22 21:12 ` Danilo Krummrich
2025-06-22 21:20 ` Benno Lossin
2025-06-22 21:24 ` Danilo Krummrich
2025-06-22 22:29 ` Benno Lossin [this message]
2025-06-23 12:01 ` Alice Ryhl
2025-06-23 12:51 ` Danilo Krummrich
2025-06-23 13:40 ` Benno Lossin
2025-06-23 13:49 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DATF1BEX3XN4.LCZYZASKZA9P@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).