From: "Alexey Klimov" <alexey.klimov@linaro.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>,
<devicetree@vger.kernel.org>, "Jaroslav Kysela" <perex@perex.cz>,
<linux-arm-msm@vger.kernel.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>, <linux-sound@vger.kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec
Date: Thu, 26 Jun 2025 12:08:56 +0100 [thread overview]
Message-ID: <DAWF24I1XW5Q.3FDHE6CS3DZBB@linaro.org> (raw)
In-Reply-To: <175090145961.2702141.17071553013552846812.robh@kernel.org>
On Thu Jun 26, 2025 at 2:30 AM BST, Rob Herring (Arm) wrote:
>
> On Thu, 26 Jun 2025 00:50:29 +0100, Alexey Klimov wrote:
>> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
>> It has TX and RX soundwire slave devices hence two files
>> are added.
>>
>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>> ---
>> .../bindings/sound/qcom,pm4125-codec.yaml | 147 +++++++++++++++++++++
>> .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml | 86 ++++++++++++
>> 2 files changed, 233 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.example.dtb: pmic@0 (qcom,pm8916): audio-codec@f000: 'qcom,micbias1-microvolt', 'qcom,micbias2-microvolt', 'qcom,micbias3-microvolt', 'qcom,rx-device', 'qcom,tx-device', 'vdd-cp-supply', 'vdd-io-supply', 'vdd-mic-bias-supply', 'vdd-pa-vpos-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.example.dtb: pmic@0 (qcom,pm8916): audio-codec@f000:compatible:0: 'qcom,pm8916-wcd-analog-codec' was expected
> from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250626-pm4125_audio_codec_v1-v1-1-e52933c429a0@linaro.org
The second patch in the series deals with that. Reordering these two patches
doesn't seem to make a lot of sense so I guess squashing it in here is
a way to go.
Thanks,
Alexey
next prev parent reply other threads:[~2025-06-26 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 23:50 [PATCH 0/3] Add PM4125 audio codec driver Alexey Klimov
2025-06-25 23:50 ` [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec Alexey Klimov
2025-06-26 1:30 ` Rob Herring (Arm)
2025-06-26 11:08 ` Alexey Klimov [this message]
2025-06-26 6:13 ` Krzysztof Kozlowski
2025-06-28 16:41 ` Alexey Klimov
2025-06-29 14:59 ` Dmitry Baryshkov
2025-06-30 8:21 ` Krzysztof Kozlowski
2025-07-01 23:30 ` Alexey Klimov
2025-07-02 6:22 ` Krzysztof Kozlowski
2025-06-25 23:50 ` [PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add " Alexey Klimov
2025-06-26 8:48 ` Krzysztof Kozlowski
2025-06-28 16:42 ` Alexey Klimov
2025-06-29 15:00 ` Dmitry Baryshkov
2025-06-30 8:18 ` Krzysztof Kozlowski
2025-06-25 23:50 ` [PATCH 3/3] ASoC: codecs: add new pm4125 audio codec driver Alexey Klimov
2025-06-26 6:19 ` Krzysztof Kozlowski
2025-07-10 15:37 ` Alexey Klimov
2025-06-26 11:56 ` Mark Brown
2025-07-01 19:35 ` Alexey Klimov
2025-07-01 21:04 ` Mark Brown
2025-07-10 14:45 ` Alexey Klimov
2025-06-28 20:24 ` Srinivas Kandagatla
2025-07-02 1:43 ` Alexey Klimov
2025-07-03 12:50 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAWF24I1XW5Q.3FDHE6CS3DZBB@linaro.org \
--to=alexey.klimov@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).