From: "Danilo Krummrich" <dakr@kernel.org>
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: "Lyude Paul" <lyude@redhat.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ben Skeggs" <bskeggs@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Dave Airlie" <airlied@redhat.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
<dri-devel@lists.freedesktop.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/nouveau: check ioctl command codes better
Date: Fri, 11 Jul 2025 20:06:14 +0200 [thread overview]
Message-ID: <DB9FBT4H5FOZ.14JZJCXMEIYU1@kernel.org> (raw)
In-Reply-To: <20250711072458.2665325-1-arnd@kernel.org>
On Fri Jul 11, 2025 at 9:24 AM CEST, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> nouveau_drm_ioctl() only checks the _IOC_NR() bits in the DRM_NOUVEAU_NVIF
> command, but ignores the type and direction bits, so any command with
> '7' in the low eight bits gets passed into nouveau_abi16_ioctl() instead
> of drm_ioctl().
>
> Check for all the bits except the size that is handled inside of the handler.
>
> Fixes: 27111a23d01c ("drm/nouveau: expose the full object/event interfaces to userspace")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to drm-misc-fixes, thanks!
[ Fix up two checkpatch warnings and a typo. - Danilo ]
next prev parent reply other threads:[~2025-07-11 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 7:24 [PATCH] drm/nouveau: check ioctl command codes better Arnd Bergmann
2025-07-11 17:41 ` Danilo Krummrich
2025-07-11 18:01 ` Arnd Bergmann
2025-07-11 18:06 ` Danilo Krummrich [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-21 12:22 Satadru Pramanik
2025-07-21 12:37 ` Arnd Bergmann
[not found] ` <CAFrh3J-SpU03=Kgi8vj1XLsMfruQyF1Rew6L2+aYUgZnkTLJAw@mail.gmail.com>
2025-07-21 13:50 ` Arnd Bergmann
2025-07-21 15:23 ` Satadru Pramanik
2025-07-22 10:29 ` Chris Bainbridge
2025-07-22 10:52 ` Arnd Bergmann
2025-07-22 11:45 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9FBT4H5FOZ.14JZJCXMEIYU1@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bskeggs@nvidia.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=ttabi@nvidia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).