Re: [PATCH v4 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

Re: [PATCH v4 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

[Gallissot Mathieu]

Hi,

I've been try to compile this patch on 6.12.33 (commit id e03ced99c437f4a7992b8fa3d97d598f55453fd0), I've got the following error messages. Which version of kernel does this patch applies?

drivers/net/wireless/nxp/nxpwifi/cmdevt.c:8:10: fatal error: asm/unaligned.h: No such file or directory
    8 | #include <asm/unaligned.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[7]: *** [scripts/Makefile.build:287: drivers/net/wireless/nxp/nxpwifi/cmdevt.o] Error 1
make[7]: *** Waiting for unfinished jobs....
  CC [M]  drivers/net/wireless/ti/wlcore/scan.o
  CC [M]  drivers/net/wireless/ti/wlcore/sysfs.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_sdio_ops.o
  CC [M]  drivers/net/wireless/ti/wlcore/vendor_cmd.o
drivers/net/wireless/nxp/nxpwifi/main.c: In function 'nxpwifi_unregister':
drivers/net/wireless/nxp/nxpwifi/main.c:114:9: error: implicit declaration of function 'del_timer_syn'; did you mean 'dev_mc_sync'? [-Werror=implicit-function-declaration]
  114 |         del_timer_sync(&adapter->cmd_timer);
      |         ^~~~~~~~~~~~~~
      |         dev_mc_sync
  CC [M]  drivers/net/wireless/rsi/rsi_91x_usb.o
drivers/net/wireless/nxp/nxpwifi/main.c: In function 'nxpwifi_main_process':
drivers/net/wireless/nxp/nxpwifi/main.c:274:25: error: implicit declaration of function 'del_timer'; did you mean 'add_timer'? [-Werror=implicit-function-declaration]
  274 |                         del_timer(&adapter->wakeup_timer);
      |                         ^~~~~~~~~
      |                         add_timer
In file included from ./include/linux/export.h:5,
                 from ./include/linux/linkage.h:7,
                 from ./include/linux/preempt.h:10,
                 from ./include/linux/spinlock.h:56,
                 from ./include/linux/swap.h:5,
                 from ./include/linux/suspend.h:5,
                 from drivers/net/wireless/nxp/nxpwifi/main.c:8:
drivers/net/wireless/nxp/nxpwifi/main.c: In function 'nxpwifi_hard_start_xmit':
drivers/net/wireless/nxp/nxpwifi/main.c:838:50: error: 'SKBTX_WIFI_STATUS' undeclared (first use in this function); did you mean 'SOCK_WIFI_STATUS'?
  838 |                      skb_shinfo(skb)->tx_flags & SKBTX_WIFI_STATUS &&
      |                                                  ^~~~~~~~~~~~~~~~~
./include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
   77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
      |                                             ^
drivers/net/wireless/nxp/nxpwifi/main.c:838:50: note: each undeclared identifier is reported only once for each function it appears in
  838 |                      skb_shinfo(skb)->tx_flags & SKBTX_WIFI_STATUS &&
      |                                                  ^~~~~~~~~~~~~~~~~
./include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
   77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
      |                                             ^
cc1: some warnings being treated as errors
drivers/net/wireless/nxp/nxpwifi/init.c: In function 'wakeup_timer_fn':
drivers/net/wireless/nxp/nxpwifi/init.c:43:43: error: implicit declaration of function 'from_timer'; did you mean 'mod_timer'? [-Werror=implicit-function-declaration]
   43 |         struct nxpwifi_adapter *adapter = from_timer(adapter, t, wakeup_timer);
      |                                           ^~~~~~~~~~
      |                                           mod_timer
drivers/net/wireless/nxp/nxpwifi/init.c:43:66: error: 'wakeup_timer' undeclared (first use in this function); did you mean 'wakeup_timer_fn'?
   43 |         struct nxpwifi_adapter *adapter = from_timer(adapter, t, wakeup_timer);
      |                                                                  ^~~~~~~~~~~~
      |                                                                  wakeup_timer_fn
drivers/net/wireless/nxp/nxpwifi/init.c:43:66: note: each undeclared identifier is reported only once for each function it appears in
make[7]: *** [scripts/Makefile.build:287: drivers/net/wireless/nxp/nxpwifi/main.o] Error 1
drivers/net/wireless/nxp/nxpwifi/init.c: In function 'nxpwifi_adapter_cleanup':
drivers/net/wireless/nxp/nxpwifi/init.c:361:9: error: implicit declaration of function 'del_timer'; did you mean 'add_timer'? [-Werror=implicit-function-declaration]
  361 |         del_timer(&adapter->wakeup_timer);
      |         ^~~~~~~~~
      |         add_timer
  CC [M]  drivers/net/wireless/rsi/rsi_91x_usb_ops.o
  CC [M]  drivers/net/wireless/ti/wlcore/sdio.o
drivers/net/wireless/nxp/nxpwifi/init.c: In function 'nxpwifi_shutdown_drv':
drivers/net/wireless/nxp/nxpwifi/init.c:577:17: error: implicit declaration of function 'del_timer_sync'; did you mean 'dev_mc_sync'? [-Werror=implicit-function-declaration]
  577 |                 del_timer_sync(&adapter->cmd_timer);
      |                 ^~~~~~~~~~~~~~
      |                 dev_mc_sync
cc1: some warnings being treated as errors

Thanks,
Mathieu

RE: [EXT] Re: [PATCH v4 00/22] wifi: nxpwifi: create nxpwifi to support iw61x

[Jeff Chen]

Hi Mathieu,

Apologies for the late reply, and thank you for catching the build errors.

I've fixed the build errors and posted the updated v5 patch series.
You can find the series here on Patchwork:
https://patchwork.kernel.org/project/linux-wireless/list/?series=988195

Thanks and regards,

Jeff

> Hi,
> 
> I've been try to compile this patch on 6.12.33 (commit id
> e03ced99c437f4a7992b8fa3d97d598f55453fd0), I've got the following error
> messages. Which version of kernel does this patch applies?
> 
> Thanks,
> Mathieu