From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: <devicetree@vger.kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
<phone-devel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
Date: Thu, 17 Jul 2025 09:20:03 +0200 [thread overview]
Message-ID: <DBE5CBN6IUD7.B03MK0X9PDFS@fairphone.com> (raw)
In-Reply-To: <175210021011.3927964.2963774922041119366.robh@kernel.org>
On Thu Jul 10, 2025 at 12:30 AM CEST, Rob Herring (Arm) wrote:
>
> On Wed, 09 Jul 2025 13:13:07 +0200, Luca Weiss wrote:
>> Document the bindings for the ADSP, CDSP, MPSS and WPSS PAS on the Milos
>> (e.g. SM7635) SoC.
>>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>> .../bindings/remoteproc/qcom,milos-pas.yaml | 201 +++++++++++++++++++++
>> 1 file changed, 201 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.example.dts:20:18: fatal error: dt-bindings/interconnect/qcom,milos-rpmh.h: No such file or directory
> 20 | #include <dt-bindings/interconnect/qcom,milos-rpmh.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I forgot to mark the milos interconnect series to be a dependency of
this.
If a resend is necessary, I can add it in v4.
Regards
Luca
> compilation terminated.
> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250709-sm7635-remoteprocs-v3-1-c943be976180@fairphone.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-17 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 11:13 [PATCH v3 0/2] Add support for remoteprocs on Milos SoC Luca Weiss
2025-07-09 11:13 ` [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs Luca Weiss
2025-07-09 22:30 ` Rob Herring (Arm)
2025-07-17 7:20 ` Luca Weiss [this message]
2025-07-21 6:42 ` Peng Fan
2025-07-21 11:38 ` Krzysztof Kozlowski
2025-07-21 13:17 ` Peng Fan
2025-07-09 11:13 ` [PATCH v3 2/2] remoteproc: qcom: pas: Add Milos remoteproc support Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBE5CBN6IUD7.B03MK0X9PDFS@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).