From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04D627EC80; Mon, 21 Jul 2025 06:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753080159; cv=none; b=q8CrhTLiCskqxWK6PuLxMY8XSBWs13l6it0UWwR9p+xhlfhrYuZzX42LCOUfpNg4DYGTabUrEGoVQ/vzA0X1FiFx1w922OEs6tUz+7JkOvmY1bVlNgdyCFPru/Z2Nf/drnm80LDVMuTGcfzCK8lXoqsEYALbSufU4orsro7H/TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753080159; c=relaxed/simple; bh=R0y01Ira8vxCv34EaQba0Oh2JfMMnOt+9HcYYnrhJ8k=; h=Content-Type:Date:Message-Id:Subject:Cc:From:To:References: In-Reply-To; b=P8Y7F4bJJC8l3mY/76P5dsGDoG1yAh67chvOW4ZFRKDXWimOpKnMlJ+VnK5HH9sjol7R6ziBooKM+WvpZAWnr8+enXaDg9YXjgDMtbPgCFUHOY4tZuvP/6XK6//cgZiOBRRj8TtXzCyui+fyzOQpWb9VxiCpjILuVNwVhDb60JU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gdgWa7zU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gdgWa7zU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7184C4CEED; Mon, 21 Jul 2025 06:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753080157; bh=R0y01Ira8vxCv34EaQba0Oh2JfMMnOt+9HcYYnrhJ8k=; h=Date:Subject:Cc:From:To:References:In-Reply-To:From; b=gdgWa7zUKhWWxVb7zMuTgFjTlM1F+8XSUbzJPspaVX2xc0YJAT2JgY3r5NY6cIRAh zh92DAxdjN0+sk/aZHrW2NVRKdvOXB1rPZZrIb8P+xytL2AkWCnI4eXpnFR6jyvtaz 3n2fufub4WDiqSlRrpxWad+N6tBteybAPGTG73n5qu7yD7UjmqgPLjnh7yNLJsaF/p PCn8rPS3j3SkC5HO1EVVqT1T3YYcFjqdIiKjOmGKxmbA79TUwZlCDZJmrVinsW0iC4 yaOksr5ZNyRJ6S3Hj9LK8bk7dedaskp1gZD3WZDeIuFHtfzJ8LailcJqBEv/TuIifz NScTJ6JNUthtA== Content-Type: multipart/signed; boundary=6493458b0ac4188a6504b0b3b194601da3c29538be77290fa402a0754a70; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Mon, 21 Jul 2025 08:42:32 +0200 Message-Id: Subject: Re: [PATCH 1/3] dt-bindings: mfd: Add power-button option for TI TPS6594 PMIC Cc: "Job Sava" , "Krzysztof Kozlowski" , "Lee Jones" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Julien Panis" , "Dmitry Torokhov" , , , From: "Michael Walle" To: "Jon Cormier" , "Jerome Neanne" , "Markus Schneider-Pargmann" X-Mailer: aerc 0.16.0 References: <20250520-linux-stable-tps6594-pwrbutton-v1-0-0cc5c6e0415c@criticallink.com> <20250520-linux-stable-tps6594-pwrbutton-v1-1-0cc5c6e0415c@criticallink.com> <20250521-wandering-tested-porpoise-acbef7@kuoka> <20250529-wise-tremendous-stork-a7d091@kuoka> <0fb4b411-1b27-43fc-8d48-e5220fc85478@kernel.org> In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: --6493458b0ac4188a6504b0b3b194601da3c29538be77290fa402a0754a70 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 [+ Jerome and Markus ] Hi, > > > > Someone knowing the device should come with arguments whether > > > > other states for this are useful at all. Or not useful and then arg= ument > > > > that in commit msg for example. > > > The other states are not useful for the kernel. Only the push button > > > has a need for an interrupt handler. The other states the PMIC handle= s > > > on its own. > > > > > > What exactly do you want me to change? > > > > Because the driver isn't setting the configuration anyway, wouldn't > > it be possible to read the config bits (Register 0x3c, bits 7-6) to > > figure out whether the pin is configured as power-button instead of > > having this property? > > > > I mean, the correct config is likely stored in the NVM anyway, and > > reconfiguring it to another value seems unlikely. > Currently, the TPS MFD driver only loads the power button driver if > the flag is set. We could put that discovery code in the MFD driver, > but what if the system designer doesn't want the power button driver? The device tree is not for configuration. The designer can just ignore the input event in that case. > I'm not sure auto detecting it makes sense. Why? > We are basing this on the other TI PMIC drivers and how they are > configured. I'm not sure I want to reinvent the wheel, so to speak. That was never a good reason. Maybe there was a reason for the TPS65219. Markus? Jerome? I haven't found anything in the commit messages or cover letters. Only that it is "optional". Not sure what that means. According to the TPS65219 datasheet, that pin if not used shall be configured as EN and be connected to VSYS. -michael --6493458b0ac4188a6504b0b3b194601da3c29538be77290fa402a0754a70 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaH3hWRIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/hFtAF/d1kdDlZUxRD9dqbtdD3Pkp9siZiMMOkP A8dvPl4Q37apv3pBGU1xvF/RwwElPKGKAYCPjkNWw/8Pjy9QYI485mpRElbm8EqP Q4yItP4WaDZtZykP4FGO1RMMYyvT5pHWopY= =4oih -----END PGP SIGNATURE----- --6493458b0ac4188a6504b0b3b194601da3c29538be77290fa402a0754a70--