From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53FD22DF95; Wed, 23 Jul 2025 19:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753300390; cv=none; b=JpI1V3YTzo/OKx3AhnKNKlVWKk9slrS4Xnd2966CXPpJf7UjeNzd37CffKudLiJ+3tA8DIlOAzEWU49AarW/4SQ12Pl4NuU242TpAxCcAq6apiwki5KSz7a/FVSL+9ohJO11Cvm2QzwuodrFsmRSKrFjGocdFJ5uF7XraXcZfww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753300390; c=relaxed/simple; bh=bSXqjeidHv3ohMhzJNgbESs/WeET08hNfS1+1fq/Zpc=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=KOHlSebpNiMqMwAEzakIpPiiaC+ruT/+ySpircdI/XlICflgqERh6BJtlWE2hh3vT/Qazwcrd7YGM+5DqF7ZBGxZvaW1opsaQeku0j6PqyPQU+ERcbrxmNPRFunT8MqFeQV8XQhlGc7FoOlGdOZbkAu06BDWu9tLQ5uQ1pymmog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MaFF0rHK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MaFF0rHK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE073C4CEE7; Wed, 23 Jul 2025 19:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753300390; bh=bSXqjeidHv3ohMhzJNgbESs/WeET08hNfS1+1fq/Zpc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MaFF0rHKz7F3eFcN09w8G7wJOFOqsrxYtr9sfNPJGq0PpywH/AlwXUhvltvJlShcq yvhFQ7gX0EbIks5kCNecUdy4xYoFH0YCXZTSQtc5lc/09lvLifpRyt9rF1E3+w4mYi Zccl2n7w8HNLcyHBrEN546D7sBCA1ixCNGyX9VcRJcuJv6yl0k67H8XB9LtiLoHMx8 KlxuzhRoETRlXuUKTFpbE+Iz0x4M3y8ucjZLM3KKyKJUp6NCXgRLn0SVjt9+6lVwGv B1aCyek1pecndAKRPFGG8klm/lWK6GzuwZcroe/SsDlX1PDbPJC6Mp9WBX2TYX0ROD XEIGz/CEKGDSQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 23 Jul 2025 21:53:05 +0200 Message-Id: From: "Benno Lossin" To: "Tamir Duberstein" , "Miguel Ojeda" Cc: "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , , Subject: Re: [PATCH v3] rust: remove spurious compiler_builtins dependents X-Mailer: aerc 0.20.1 References: <20250720-rust-remove-compiler-builtins-deps-v3-1-0df3a493973f@gmail.com> In-Reply-To: On Wed Jul 23, 2025 at 5:18 PM CEST, Tamir Duberstein wrote: > On Mon, Jul 21, 2025 at 8:25=E2=80=AFAM Miguel Ojeda > wrote: >> >> On Sun, Jul 20, 2025 at 7:20=E2=80=AFPM Tamir Duberstein wrote: >> > >> > Remove these dependency edges. >> >> I should have replied in previous versions: this is wrong -- the 3 >> changes each individually break the build. >> >> I guess that you are not cleaning everything in your tests before >> testing the build. > > You're absolutely right, this patch is incorrect. I was indeed not > blowing away build artifcats. So is the `compiler_builtins` dependency correct for all crates? --- Cheers, Benno