From: "Benno Lossin" <lossin@kernel.org>
To: "herculoxz" <abhinav.ogl@gmail.com>, <linux-pci@vger.kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dakr@kernel.org>, <bhelgaas@google.com>,
<kwilczynski@kernel.org>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<a.hindborg@kernel.org>, <aliceryhl@google.com>,
<tmgross@umich.edu>
Subject: Re: [PATCH v2] rust: pci: Use explicit types in FFI callbacks
Date: Tue, 29 Jul 2025 18:35:54 +0200 [thread overview]
Message-ID: <DBOOOGFNK5YV.1B67YLP2GBD2A@kernel.org> (raw)
In-Reply-To: <20250729102953.141412-1-abhinav.ogl@gmail.com>
On Tue Jul 29, 2025 at 12:29 PM CEST, herculoxz wrote:
> From: Abhinav Ananthu <abhinav.ogl@gmail.com>
>
> Update PCI FFI callback signatures to use `c_int` from the prelude,
> instead of accessing it via `kernel::ffi::c_int`.
>
> This follows Rust-for-Linux coding guidelines and improves ABI
> correctness when interfacing with C code.
>
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
Reviewed-by: Benno Lossin <lossin@kernel.org>
---
Cheers,
Benno
> ---
> rust/kernel/pci.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
prev parent reply other threads:[~2025-07-29 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 10:29 [PATCH v2] rust: pci: Use explicit types in FFI callbacks herculoxz
2025-07-29 10:52 ` Miguel Ojeda
2025-07-29 14:45 ` Danilo Krummrich
2025-07-30 7:56 ` Alice Ryhl
2025-07-29 16:35 ` Benno Lossin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBOOOGFNK5YV.1B67YLP2GBD2A@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=abhinav.ogl@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).