From: "Danilo Krummrich" <dakr@kernel.org>
To: "Vitaly Wool" <vitaly.wool@konsulko.se>
Cc: <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
<rust-for-linux@vger.kernel.org>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Kent Overstreet" <kent.overstreet@linux.dev>,
<linux-bcachefs@vger.kernel.org>, <bpf@vger.kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Jann Horn" <jannh@google.com>,
"Pedro Falcato" <pfalcato@suse.de>
Subject: Re: [PATCH v14 4/4] rust: support large alignments in allocations
Date: Wed, 30 Jul 2025 22:18:57 +0200 [thread overview]
Message-ID: <DBPO1RQMZDH2.2WFOZO0X4DODN@kernel.org> (raw)
In-Reply-To: <20250730192101.358943-1-vitaly.wool@konsulko.se>
On Wed Jul 30, 2025 at 9:21 PM CEST, Vitaly Wool wrote:
> diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs
> index d19c06ef0498..17b27c6e9e37 100644
> --- a/rust/kernel/alloc/allocator_test.rs
> +++ b/rust/kernel/alloc/allocator_test.rs
> @@ -40,6 +40,7 @@ unsafe fn realloc(
> layout: Layout,
> old_layout: Layout,
> flags: Flags,
> + nid: NumaNode,
> ) -> Result<NonNull<[u8]>, AllocError> {
> let src = match ptr {
> Some(src) => {
I think this hunk should be on patch 3.
Also, don't you see a warning when running the rusttest target? I think it has
to be _nid, given that the argument is unused.
next prev parent reply other threads:[~2025-07-30 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 19:19 [PATCH v14 0/4] support large align and nid in Rust allocators Vitaly Wool
2025-07-30 19:20 ` [PATCH v14 1/4] :mm/vmalloc: allow to set node and align in vrealloc Vitaly Wool
2025-07-31 12:07 ` Lorenzo Stoakes
2025-07-30 19:20 ` [PATCH v14 2/4] mm/slub: allow to set node and align in k[v]realloc Vitaly Wool
2025-08-01 10:22 ` Vlastimil Babka
2025-07-30 19:20 ` [PATCH v14 3/4] rust: add support for NUMA ids in allocations Vitaly Wool
2025-07-30 19:21 ` [PATCH v14 4/4] rust: support large alignments " Vitaly Wool
2025-07-30 20:18 ` Danilo Krummrich [this message]
2025-07-31 9:02 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBPO1RQMZDH2.2WFOZO0X4DODN@kernel.org \
--to=dakr@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=bpf@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jannh@google.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=rust-for-linux@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).