* [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225
@ 2025-07-23 14:19 Luca Weiss
2025-07-23 14:21 ` Luca Weiss
2025-07-23 19:03 ` Dmitry Baryshkov
0 siblings, 2 replies; 6+ messages in thread
From: Luca Weiss @ 2025-07-23 14:19 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Clark, Dmitry Baryshkov
Cc: ~postmarketos/upstreaming, phone-devel, Konrad Dybcio,
linux-arm-msm, linux-kernel, Luca Weiss
SM7225 is a variation of SM6350, and also needs an entry in the table.
Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Note, due to other bugs on next-20250723 I couldn't fully test that
DPU/GPU are working, but this seems to be required in any case...
---
drivers/soc/qcom/ubwc_config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index bd0a98aad9f3b222abcf0a7af85a318caffa9841..9fdd169f87a78a486bea8823083bef08bc5b9521 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -246,6 +246,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
{ .compatible = "qcom,sm6375", .data = &sm6350_data, },
{ .compatible = "qcom,sm7125", .data = &sc7180_data },
{ .compatible = "qcom,sm7150", .data = &sm7150_data, },
+ { .compatible = "qcom,sm7225", .data = &sm6350_data, },
{ .compatible = "qcom,sm8150", .data = &sm8150_data, },
{ .compatible = "qcom,sm8250", .data = &sm8250_data, },
{ .compatible = "qcom,sm8350", .data = &sm8350_data, },
---
base-commit: ac3f0fb04c50a909908fd375686c5ad6b27bee98
change-id: 20250723-ubwc-sm7225-19be7c2e7bdd
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225
2025-07-23 14:19 [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225 Luca Weiss
@ 2025-07-23 14:21 ` Luca Weiss
2025-07-23 19:03 ` Dmitry Baryshkov
1 sibling, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2025-07-23 14:21 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Clark,
Dmitry Baryshkov
Cc: ~postmarketos/upstreaming, phone-devel, Konrad Dybcio,
linux-arm-msm, linux-kernel
On Wed Jul 23, 2025 at 4:19 PM CEST, Luca Weiss wrote:
> SM7225 is a variation of SM6350, and also needs an entry in the table.
And now a second after sending I checked sm7325 and that's also
missing...
>
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Note, due to other bugs on next-20250723 I couldn't fully test that
> DPU/GPU are working, but this seems to be required in any case...
> ---
> drivers/soc/qcom/ubwc_config.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
> index bd0a98aad9f3b222abcf0a7af85a318caffa9841..9fdd169f87a78a486bea8823083bef08bc5b9521 100644
> --- a/drivers/soc/qcom/ubwc_config.c
> +++ b/drivers/soc/qcom/ubwc_config.c
> @@ -246,6 +246,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
> { .compatible = "qcom,sm6375", .data = &sm6350_data, },
> { .compatible = "qcom,sm7125", .data = &sc7180_data },
> { .compatible = "qcom,sm7150", .data = &sm7150_data, },
> + { .compatible = "qcom,sm7225", .data = &sm6350_data, },
> { .compatible = "qcom,sm8150", .data = &sm8150_data, },
> { .compatible = "qcom,sm8250", .data = &sm8250_data, },
> { .compatible = "qcom,sm8350", .data = &sm8350_data, },
>
> ---
> base-commit: ac3f0fb04c50a909908fd375686c5ad6b27bee98
> change-id: 20250723-ubwc-sm7225-19be7c2e7bdd
>
> Best regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225
2025-07-23 14:19 [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225 Luca Weiss
2025-07-23 14:21 ` Luca Weiss
@ 2025-07-23 19:03 ` Dmitry Baryshkov
2025-08-11 18:32 ` Bjorn Andersson
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-07-23 19:03 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Konrad Dybcio, Rob Clark,
~postmarketos/upstreaming, phone-devel, Konrad Dybcio,
linux-arm-msm, linux-kernel
On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
> SM7225 is a variation of SM6350, and also needs an entry in the table.
>
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Note, due to other bugs on next-20250723 I couldn't fully test that
> DPU/GPU are working, but this seems to be required in any case...
> ---
> drivers/soc/qcom/ubwc_config.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225
2025-07-23 19:03 ` Dmitry Baryshkov
@ 2025-08-11 18:32 ` Bjorn Andersson
2025-08-12 11:10 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2025-08-11 18:32 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Luca Weiss, Konrad Dybcio, Rob Clark, ~postmarketos/upstreaming,
phone-devel, Konrad Dybcio, linux-arm-msm, linux-kernel
On Wed, Jul 23, 2025 at 10:03:15PM +0300, Dmitry Baryshkov wrote:
> On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
> > SM7225 is a variation of SM6350, and also needs an entry in the table.
> >
> > Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> > Note, due to other bugs on next-20250723 I couldn't fully test that
> > DPU/GPU are working, but this seems to be required in any case...
> > ---
> > drivers/soc/qcom/ubwc_config.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
@Dmitry will you pick this as well through your tree, so we avoid (the
trivial) conflict.
Acked-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225
2025-08-11 18:32 ` Bjorn Andersson
@ 2025-08-12 11:10 ` Dmitry Baryshkov
2025-08-12 15:21 ` Luca Weiss
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-08-12 11:10 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Luca Weiss, Konrad Dybcio, Rob Clark, ~postmarketos/upstreaming,
phone-devel, Konrad Dybcio, linux-arm-msm, linux-kernel
On Mon, Aug 11, 2025 at 01:32:00PM -0500, Bjorn Andersson wrote:
> On Wed, Jul 23, 2025 at 10:03:15PM +0300, Dmitry Baryshkov wrote:
> > On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
> > > SM7225 is a variation of SM6350, and also needs an entry in the table.
> > >
> > > Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > > ---
> > > Note, due to other bugs on next-20250723 I couldn't fully test that
> > > DPU/GPU are working, but this seems to be required in any case...
> > > ---
> > > drivers/soc/qcom/ubwc_config.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> >
>
> @Dmitry will you pick this as well through your tree, so we avoid (the
> trivial) conflict.
Yes
>
> Acked-by: Bjorn Andersson <andersson@kernel.org>
>
> Regards,
> Bjorn
>
> >
> > --
> > With best wishes
> > Dmitry
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225
2025-08-12 11:10 ` Dmitry Baryshkov
@ 2025-08-12 15:21 ` Luca Weiss
0 siblings, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2025-08-12 15:21 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson
Cc: Konrad Dybcio, Rob Clark, ~postmarketos/upstreaming, phone-devel,
Konrad Dybcio, linux-arm-msm, linux-kernel
On Tue Aug 12, 2025 at 1:10 PM CEST, Dmitry Baryshkov wrote:
> On Mon, Aug 11, 2025 at 01:32:00PM -0500, Bjorn Andersson wrote:
>> On Wed, Jul 23, 2025 at 10:03:15PM +0300, Dmitry Baryshkov wrote:
>> > On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
>> > > SM7225 is a variation of SM6350, and also needs an entry in the table.
>> > >
>> > > Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
>> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> > > ---
>> > > Note, due to other bugs on next-20250723 I couldn't fully test that
>> > > DPU/GPU are working, but this seems to be required in any case...
>> > > ---
>> > > drivers/soc/qcom/ubwc_config.c | 1 +
>> > > 1 file changed, 1 insertion(+)
>> > >
>> >
>> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> >
>>
>> @Dmitry will you pick this as well through your tree, so we avoid (the
>> trivial) conflict.
>
> Yes
Could you maybe amend this patch to also add sm7325?
Or check if any other compatibles were left out in ubwc_config.c which
are used upstream, I didn't check...
Regards
Luca
>
>>
>> Acked-by: Bjorn Andersson <andersson@kernel.org>
>>
>> Regards,
>> Bjorn
>>
>> >
>> > --
>> > With best wishes
>> > Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-08-12 15:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 14:19 [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225 Luca Weiss
2025-07-23 14:21 ` Luca Weiss
2025-07-23 19:03 ` Dmitry Baryshkov
2025-08-11 18:32 ` Bjorn Andersson
2025-08-12 11:10 ` Dmitry Baryshkov
2025-08-12 15:21 ` Luca Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).