linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: <akpm@linux-foundation.org>, <ojeda@kernel.org>,
	<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
	<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
	<lossin@kernel.org>, <a.hindborg@kernel.org>,
	<aliceryhl@google.com>, <tmgross@umich.edu>,
	<abdiel.janulgue@gmail.com>, <acourbot@nvidia.com>,
	<jgg@ziepe.ca>, <lyude@redhat.com>, <robin.murphy@arm.com>,
	<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] rust: dma: add type alias for bindings::dma_addr_t
Date: Tue, 26 Aug 2025 19:33:49 +0200	[thread overview]
Message-ID: <DCCJG1V40J97.1FQA6ZV5JE6RK@kernel.org> (raw)
In-Reply-To: <CE0E1F73-69CE-4629-979E-9AE5B6AB055E@collabora.com>

On Tue Aug 26, 2025 at 7:15 PM CEST, Daniel Almeida wrote:
> Hmm, I wonder if this shouldn’t be its own type, instead of an alias. This
> will be handy if we want to enforce that a given address is, in fact, a bus
> address.

I'm not sure I understand the idea. How can a new type compared to a type alias
help to guarantee that a DMA address is also a bus address?

This depends on whether there is an IOMMU, etc.

> In any case, this can be a separate patch. This one is good.
>
>
> Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>


  reply	other threads:[~2025-08-26 17:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 13:24 [PATCH v3 0/5] Rust infrastructure for sg_table and scatterlist Danilo Krummrich
2025-08-25 13:24 ` [PATCH v3 1/5] rust: dma: implement DataDirection Danilo Krummrich
2025-08-26 17:10   ` Daniel Almeida
2025-08-25 13:24 ` [PATCH v3 2/5] rust: dma: add type alias for bindings::dma_addr_t Danilo Krummrich
2025-08-26 17:15   ` Daniel Almeida
2025-08-26 17:33     ` Danilo Krummrich [this message]
2025-08-26 19:58       ` Daniel Almeida
2025-08-25 13:24 ` [PATCH v3 3/5] rust: scatterlist: Add abstraction for sg_table Danilo Krummrich
2025-08-26 14:16   ` Alice Ryhl
2025-08-26 14:32     ` Danilo Krummrich
2025-08-26 17:41       ` Daniel Almeida
2025-08-26 14:36   ` Alexandre Courbot
2025-08-26 15:18     ` Danilo Krummrich
2025-08-26 17:45       ` Daniel Almeida
2025-08-26 23:38       ` Danilo Krummrich
2025-08-27  8:30       ` Alexandre Courbot
2025-08-26 17:40   ` Daniel Almeida
2025-08-26 19:13     ` Danilo Krummrich
2025-08-26 20:16       ` Daniel Almeida
2025-08-26 20:27         ` Danilo Krummrich
2025-08-25 13:24 ` [PATCH v3 4/5] samples: rust: dma: add sample code for SGTable Danilo Krummrich
2025-08-26 14:38   ` Alexandre Courbot
2025-08-26 17:46   ` Daniel Almeida
2025-08-25 13:24 ` [PATCH v3 5/5] MAINTAINERS: rust: dma: add scatterlist files Danilo Krummrich
2025-08-28 10:19   ` Miguel Ojeda
2025-08-26 21:01 ` [PATCH v3 0/5] Rust infrastructure for sg_table and scatterlist Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCCJG1V40J97.1FQA6ZV5JE6RK@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).