From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: <akpm@linux-foundation.org>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>,
<abdiel.janulgue@gmail.com>, <acourbot@nvidia.com>,
<jgg@ziepe.ca>, <lyude@redhat.com>, <robin.murphy@arm.com>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] rust: scatterlist: Add abstraction for sg_table
Date: Tue, 26 Aug 2025 22:27:00 +0200 [thread overview]
Message-ID: <DCCN4NA8LSGD.10TKRH3LRGAEN@kernel.org> (raw)
In-Reply-To: <3BD5A415-CD19-4B8E-A2A3-78F60FCC863A@collabora.com>
On Tue Aug 26, 2025 at 10:16 PM CEST, Daniel Almeida wrote:
> // SAFETY: It is not possible to mutate a `SGEntry` through a shared reference,
> // so it is safe to send a &SGEntry to another task.
>
> Or any variation of the wording above.
>
> In any case, I agree that this is splitting hairs a bit and I have nothing
> against keeping it as-is, I just thought it be a tad clearer :)
Yeah, that's what I meant. The definition of Sync even says "Types that are not
Sync are those that have interior mutability in a non-thread-safe form [...]".
[1].
So, both our wordings basically come down to "It's Sync because it's Sync." :)
But don't get me wrong, I'm fine being a bit more verbose about this.
[1] https://doc.rust-lang.org/std/marker/trait.Sync.html
next prev parent reply other threads:[~2025-08-26 20:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 13:24 [PATCH v3 0/5] Rust infrastructure for sg_table and scatterlist Danilo Krummrich
2025-08-25 13:24 ` [PATCH v3 1/5] rust: dma: implement DataDirection Danilo Krummrich
2025-08-26 17:10 ` Daniel Almeida
2025-08-25 13:24 ` [PATCH v3 2/5] rust: dma: add type alias for bindings::dma_addr_t Danilo Krummrich
2025-08-26 17:15 ` Daniel Almeida
2025-08-26 17:33 ` Danilo Krummrich
2025-08-26 19:58 ` Daniel Almeida
2025-08-25 13:24 ` [PATCH v3 3/5] rust: scatterlist: Add abstraction for sg_table Danilo Krummrich
2025-08-26 14:16 ` Alice Ryhl
2025-08-26 14:32 ` Danilo Krummrich
2025-08-26 17:41 ` Daniel Almeida
2025-08-26 14:36 ` Alexandre Courbot
2025-08-26 15:18 ` Danilo Krummrich
2025-08-26 17:45 ` Daniel Almeida
2025-08-26 23:38 ` Danilo Krummrich
2025-08-27 8:30 ` Alexandre Courbot
2025-08-26 17:40 ` Daniel Almeida
2025-08-26 19:13 ` Danilo Krummrich
2025-08-26 20:16 ` Daniel Almeida
2025-08-26 20:27 ` Danilo Krummrich [this message]
2025-08-25 13:24 ` [PATCH v3 4/5] samples: rust: dma: add sample code for SGTable Danilo Krummrich
2025-08-26 14:38 ` Alexandre Courbot
2025-08-26 17:46 ` Daniel Almeida
2025-08-25 13:24 ` [PATCH v3 5/5] MAINTAINERS: rust: dma: add scatterlist files Danilo Krummrich
2025-08-28 10:19 ` Miguel Ojeda
2025-08-26 21:01 ` [PATCH v3 0/5] Rust infrastructure for sg_table and scatterlist Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCCN4NA8LSGD.10TKRH3LRGAEN@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).