* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
@ 2025-08-28 14:53 ` Vladimir Zapolskiy
2025-08-28 18:36 ` Rui Miguel Silva
2025-08-29 16:52 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2025-08-28 14:53 UTC (permalink / raw)
To: Frank Li, Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 8/27/25 22:49, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> index 634d3b821b8c7..ec5c40684b6bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> @@ -58,7 +58,7 @@ properties:
> properties:
> endpoint:
> $ref: /schemas/media/video-interfaces.yaml#
> - additionalProperties: false
> + unevaluatedProperties: false
>
> properties:
> link-frequencies: true
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
@ 2025-08-28 18:36 ` Rui Miguel Silva
2025-08-29 16:52 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rui Miguel Silva @ 2025-08-28 18:36 UTC (permalink / raw)
To: Frank Li, Rui Miguel Silva, Hans de Goede, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OMNIVISION OV2680 SENSOR DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Hi Frank,
Thanks for the patch.
On Wed Aug 27, 2025 at 8:49 PM WEST, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
LGTM.
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Cheers,
Rui
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> index 634d3b821b8c7..ec5c40684b6bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> @@ -58,7 +58,7 @@ properties:
> properties:
> endpoint:
> $ref: /schemas/media/video-interfaces.yaml#
> - additionalProperties: false
> + unevaluatedProperties: false
>
> properties:
> link-frequencies: true
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint
2025-08-27 19:49 [PATCH 1/1] media: dt-bindings: ovti,ov2680: Use unevaluatedProperties for endpoint Frank Li
2025-08-28 14:53 ` Vladimir Zapolskiy
2025-08-28 18:36 ` Rui Miguel Silva
@ 2025-08-29 16:52 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-08-29 16:52 UTC (permalink / raw)
To: Frank Li
Cc: Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Rui Miguel Silva, devicetree, Hans de Goede, imx, linux-kernel,
linux-media
On Wed, 27 Aug 2025 15:49:18 -0400, Frank Li wrote:
> The endpoint ref to /schemas/media/video-interfaces.yaml#, so replace
> additionalProperties with unevaluatedProperties to allow use common
> properties.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36 (ovti,ov2680): port:endpoint: 'clock-lanes', 'data-lanes' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread