Re: [PATCH v2 4/4] rust: Move register and bitstruct macros out of Nova

Miguel Ojeda
2025-09-07T18:15:03Z

Hi Joel,

I didn't check the macros, but a couple nits I noticed in this patch
in particular given it moved it to `kernel`...

On Wed, Sep 3, 2025 at 11:54 PM Joel Fernandes <joelagnelf@nvidia.com> wrote:
>
> +//! A library that provides support for defining bit fields in Rust

What about just "Support for defining bit fields in ..." or similar?

> +//! structures. Also used from things that need bitfields like register macro.

The "register macro" part sounds like it should be formatted with
Markdown plus an intra-doc link.

> - ::kernel::build_assert!(
> + build_assert!(

Is this path unqualified for some reason? Does it mean the user needs
to have imported the prelude?

> +pub use super::{bitstruct, register};

Please justify in the commit message why we want them in the prelude,
e.g. are they expected to be common? Does it simplify some code? etc.

Thanks!

Cheers,
Miguel