Re: [PATCH net v5 5/5] net: macb: avoid dealing with endianness in macb_set_hwaddr()

Théo Lebrun
2025-09-11T09:23:13Z

On Thu Sep 11, 2025 at 5:13 AM CEST, Karumanchi, Vineeth wrote:
> On 9/10/2025 9:45 PM, Théo Lebrun wrote:
>> @@ -271,12 +271,10 @@ static bool hw_is_gem(void __iomem *addr, bool native_io)
>>
>> static void macb_set_hwaddr(struct macb *bp)
>> {
>> - u32 bottom;
>> - u16 top;
>> + u32 bottom = get_unaligned_le32(bp->dev->dev_addr);
>> + u16 top = get_unaligned_le16(bp->dev->dev_addr + 4);
>
> please change the order as per reverse xmas tree.

I had realised this before sending the patch but preferred keeping the
ordering as-is to access dev_addr+0 first then dev_addr+4.

RCT is a strict rule in net so I'll fix it in the next revision. Some
sneaky options were also considered: a spare space in the `u32 bottom`
line, express bottom using `dev_addr + 0`, or renaming variables. :-)

Thanks Vineeth,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering