From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF3631C695 for ; Sun, 14 Sep 2025 08:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757839920; cv=none; b=LZXdXPAcSARriKab46/WWD0g+AL9NKPdOOC4XkENorePbisTlFxs7lB0hTQhRHijq1FfTQ3QM7fA9nRET+bfsoS8XoOAsc1qLl/3qj/8YCzPGpwYq59a+Aty7se0ZIFwrSQS6zZtsdR+9vS1Ji+MWyvds9k1Bnut7mDpPqrJmgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757839920; c=relaxed/simple; bh=pu0GrjYYfzlRG9ePNGfLSB1xjWRol2JFlYQ+Bg4jd5Y=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=EcBRcMCIpHHwmhOPcrLG258BvD3xsD7DbdKF0tv447b+4rFWRmAPjtBppdAFiVBamIDRi9ynPS64sTfW992kmYBsbeGeIC2czOLfXp4DB8Q2CFo56WLEGqiIhge/jXchkWWC9eRSx8+mvmLkinf5PIS880sghQh0AIwPvSUVFVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nh/TIy0Z; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nh/TIy0Z" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-77616dce48cso1351924b3a.0 for ; Sun, 14 Sep 2025 01:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757839918; x=1758444718; darn=vger.kernel.org; h=in-reply-to:references:cc:subject:from:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9xYB2/4f3FmpIxcEv4UNcJMbm9iSz8Dk35nkey4DobA=; b=nh/TIy0ZC+LHXN0xeF8ymZPWBOzecpqfCtZLHmKhRNthcfS2IaYYp0pu36JWxizD8Q GC4BysKgm7HNivJvOb8SaL5CqWR6REy27rbKezKw8FwfhXt0pIPSZj5+KPPyliTqfAHR /xO/kKMNfAmcEw1gateIfAb7T/V6OzI6jPeQpFYpx0h+PO2CjGVIdnaOe0wPfsAM6Q5J LnoQ1pULLfrQPoO0HtOVgqRfQO7lGR68zVXK+v/uqzg2c9aWNE95AEICT9H0qO86HN2P Gqot6QuwMUJJiAvAp4YrHk7JWrL1IoD7IO6dKFOqtkgCiA409gg4qv/3XjnNpgttcvqP wwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757839918; x=1758444718; h=in-reply-to:references:cc:subject:from:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9xYB2/4f3FmpIxcEv4UNcJMbm9iSz8Dk35nkey4DobA=; b=ILORpDC8un1KqGE5z5SZy5i6exkU1Nmi24G9i74RmJalBVrrnsrCrSyZ6mLbjCzUCq 3CkiQGyVSW3MAaV3gpeZ5TXueximDCJwKd/8AgZcxjDlHJHqTJ5DH3rvqR0DJ4TuJLEn 3KKKhn/SkMeieRzJqnqru/dPaHhJSNk6uwVLOZ1S28VU6J1cqbe8QQQ7sYlsaYosT2l/ 7dI0i+WyNvmHwYnzrJS9mGhgMWFt6utBnrxNRtROUpjaz15z6ujUglKMIh/MLVSrIEzs /TT242EUepOVl27CWL7vOJhq7OGELcQU9YxTpOGzwExvh92uy8Z4i5QQNKIoJGb6R5g3 2JYA== X-Forwarded-Encrypted: i=1; AJvYcCUcCp5nP4OW6982TQEQOZz2hziNGK6pRzP2482Fqm8lLiwCHJWVsGfngU48WeFA7j1xiDHI4YSUIrAjehs=@vger.kernel.org X-Gm-Message-State: AOJu0YwYc49s495s6C8r7TukPVcsbXNyJHm3j/mc4eiHN361cQ7pFtSA zuaQT1lMkpO4ofpT7INsK9qYzwYaFf+urdivjk9xE/94tvLSjzzFdo7G X-Gm-Gg: ASbGncuUD8gLMV+BshEu1bSId0T0ZRSk1NHNtdb0rAWzHZz4MxX5EKBk91aZy6hUczZ /8WG6h7RXapJJ5RU8QV0v51p+pWtq8z+MXVZV/lYxDqg/Ojs0agYpjrbkmKxD8SNuVAhsIuC0EN oW5w8jPOc4Z7BwlcmpnfhaRjn2b09vGQVA4opUrl3g+lN99dfVC8+qdWfV4+tFWwQc8AL1P+AT7 zQ1ijCWvmYhEohCx2cJfLcOZEcF+qn9B9Ho+N+fngwyGWZBvTdI/wofa+WMSlafVBykPQPth7Zh VIyDMAibr9b08aN7AoCYbIsPXyKLweQkrAHad7GG9IyKH7fDxqp7X9dDvlUiJ4RRRzNKAwg3Wqp zd9FRNoUhc8IMogGjc2opR1XHW7tke6KS1qzSlGICrwqlN6u347opB4G0rQMuGRU= X-Google-Smtp-Source: AGHT+IGBCGF/62swHad3RbhGMxjfqONlAZq9ze+mDcHFiwssxclDQ9ZkAqX+WR2tZzKT+yzYuyr5Pw== X-Received: by 2002:a05:6a20:a10a:b0:24c:c33e:8df0 with SMTP id adf61e73a8af0-2602c72030emr10783930637.45.1757839917945; Sun, 14 Sep 2025 01:51:57 -0700 (PDT) Received: from localhost ([121.159.229.173]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b54a387cc21sm8937206a12.28.2025.09.14.01.51.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Sep 2025 01:51:57 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 14 Sep 2025 17:51:54 +0900 Message-Id: To: "Andrew Lunn" From: "Yeounsu Moon" Subject: Re: [PATCH net] net: dlink: handle copy_thresh allocation failure Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , , X-Mailer: aerc 0.20.1 References: <20250912145339.67448-2-yyyynoom@gmail.com> <57d58296-c656-4dab-a2e2-faf2452fb4de@lunn.ch> In-Reply-To: <57d58296-c656-4dab-a2e2-faf2452fb4de@lunn.ch> On Sat Sep 13, 2025 at 5:39 AM KST, Andrew Lunn wrote: >> - skb_copy_to_linear_data (skb, >> + skb_copy_to_linear_data(skb, >> np->rx_skbuff[entry]->data, >> pkt_len); >> - skb_put (skb, pkt_len); >> + skb_put(skb, pkt_len); > > Please don't include white space changes with other changes. It makes > the patch harder to review. > > Andrew Thank you for reviewing! As you mentioned, it indeed becomes harder to see what the real changes are. I have a few questions related to that: 1. If I remove the whitespace between the funciton name and the parenthesis, `checkpatch.pl` will warn about it. Of course, I understand that we don't need to follow such rules in a mindessly robotic way. 2. However, I also read in the netdev FAQ that cleanup-only patches are discouraged. So I thought it would be better to include the cleanup together with the patch. But I see your point, and I'll be more careful not to send patches that cause such confusion in the future. 3. This is more of a personal curiosity: in that case, what would be the proper way to handle cleanup patches? Yeounsu Moon