From: "Danilo Krummrich" <dakr@kernel.org>
To: "Mohamed Ahmed" <mohamedahmedegypt2001@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
"Mary Guillemard" <mary@mary.zone>,
"Faith Ekstrand" <faith.ekstrand@collabora.com>,
"Lyude Paul" <lyude@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
<nouveau@lists.freedesktop.org>
Subject: Re: [PATCH 2/5] drm/nouveau/uvmm: Allow larger pages
Date: Thu, 09 Oct 2025 22:09:42 +0200 [thread overview]
Message-ID: <DDE2BDLEZHBW.253EO66P7ZH2P@kernel.org> (raw)
In-Reply-To: <CAA+WOBvu2Gq=SM2TBdahsQ-RVi+vn_U-oDa7-DG6kj9Arq5tpA@mail.gmail.com>
On Thu Oct 9, 2025 at 6:51 PM CEST, Mohamed Ahmed wrote:
>> Let's move the call to select_page_shift() into op_map_prepare().
>
> How would this work? Originally when we were working on this, we did
> place it in op_map_prepare() but we ran into the issue where
> nouveau_uvmm_vmm_put() needed the page_shift retrieved (see
> nouveau_uvmm_sm_prepare_unwind()).
- ret = op_map_prepare(uvmm, &new->map, &op->map, args, PAGE_SHIFT);
+ ret = op_map_prepare(uvmm, &new->map, &op->map, args,
+ select_page_shift(uvmm, &op->map));
You can move this call to select_page_shift() into op_map_prepare(), that's not
related to nouveau_uvmm_sm_prepare_unwind(), right?
next prev parent reply other threads:[~2025-10-09 20:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 19:13 [PATCH 0/5] drm/nouveau: Enable variable page sizes and compression Mohamed Ahmed
2025-10-06 19:13 ` [PATCH 1/5] drm/nouveau/uvmm: Prepare for larger pages Mohamed Ahmed
2025-10-06 19:13 ` [PATCH 2/5] drm/nouveau/uvmm: Allow " Mohamed Ahmed
2025-10-06 20:26 ` Danilo Krummrich
2025-10-09 16:51 ` Mohamed Ahmed
2025-10-09 20:09 ` Danilo Krummrich [this message]
2025-10-09 23:40 ` Mohamed Ahmed
2025-10-06 19:13 ` [PATCH 3/5] drm/nouveau/mmu/gp100: Remove unused/broken support for compression Mohamed Ahmed
2025-10-06 20:27 ` Danilo Krummrich
2025-10-06 19:13 ` [PATCH 4/5] drm/nouveau/mmu/tu102: Add support for compressed kinds Mohamed Ahmed
2025-10-06 19:13 ` [PATCH 5/5] drm/nouveau/drm: Bump the driver version to 1.4.1 to report new features Mohamed Ahmed
2025-10-06 20:29 ` Danilo Krummrich
-- strict thread matches above, loose matches on Subject: below --
2025-10-09 23:38 [PATCH 0/5 v2] drm/nouveau: Enable variable page sizes and compression Mohamed Ahmed
2025-10-09 23:38 ` [PATCH 2/5] drm/nouveau/uvmm: Allow larger pages Mohamed Ahmed
2025-10-22 10:16 ` Mohamed Ahmed
2025-10-22 20:56 ` Danilo Krummrich
2025-10-22 21:09 ` Lyude Paul
2025-10-22 21:39 ` Mary Guillemard
2025-10-23 10:14 ` Mohamed Ahmed
2025-10-23 20:51 ` Lyude Paul
2025-10-24 18:38 ` M Henning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDE2BDLEZHBW.253EO66P7ZH2P@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mary@mary.zone \
--cc=mohamedahmedegypt2001@gmail.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox